Repository navigation
Bootstrap: use logger.hpp and THROW() - #952
Merged
Binyang Li (Binyang2014) merged 1 commit intoNov 6, 2026
Merged
Binyang Li (Binyang2014) merged 1 commit into
Binyang Li (Binyang2014) merged 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Binyang Li (Binyang2014)
approved these changes
Nov 6, 2026
Binyang Li (Binyang2014)
merged commit Nov 6, 2026
59cfa81
into
microsoft:binyli/bootstrap
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #951, based on
binyli/bootstrap.This minimal change migrates
bootstrap.ccfromdebug.htologger.hpp, maps legacyTRACEdiagnostics toDEBUG(NET, ...), and routesErrorthrows throughTHROW(NET, ...). Bootstrap flow andErrorCodevalues are preserved;THROWadds logger metadata to thrown error messages.Validation completed: clang-format, diff whitespace, logger-macro syntax, and patch applicability checks. Full build and bootstrap tests were not run because no
nvcc,hipcc, or CUDA runtime headers are available; GPU execution was not authorized.