Skip to content

Set _mi_process_is_initialized before mi_process_setup_auto_thread_done (fixes 439dc27b with MI_TLS_RECURSE_GUARD) #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LongYinan (Brooooooklyn) wants to merge 1 commit into
base: dev3
Choose a base branch
from
+2 −2
Open

Set _mi_process_is_initialized before mi_process_setup_auto_thread_done (fixes 439dc27b with MI_TLS_RECURSE_GUARD) #1399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/init.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,8 @@ static void mi_process_init_once(void) {
// the following can potentially allocate (on freeBSD for pthread keys)
_mi_tls_slots_init(); // pthread key create
_mi_thread_locals_init(); // pthread key create
mi_process_setup_auto_thread_done(); // after the above mi_thread_init so it can add the current theap
_mi_process_is_initialized = true;
_mi_process_is_initialized = true; // before `mi_process_setup_auto_thread_done` so `_mi_theap_default` returns the current theap with `MI_TLS_RECURSE_GUARD`
mi_process_setup_auto_thread_done(); // after the above mi_thread_init so it can add the current theap

#if defined(_WIN32) && defined(MI_WIN_INIT_USE_FLS)
// On windows, when building as a static lib the FLS cleanup happens to early for the main thread.
Expand Down