fix missing semicolon after mi_track_done() (ETW build failure)#1330
Open
duchy wants to merge 1 commit into
Open
fix missing semicolon after mi_track_done() (ETW build failure)#1330duchy wants to merge 1 commit into
duchy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mi_track_done()inmi_process_done()(src/init.c) is missing a trailing semicolon.When ETW tracking is enabled (
-DMI_TRACK_ETW=1), the macro expands to a real function call (EventUnregistermicrosoft_windows_mimalloc()), which then lacks a statement terminator. This causes a hard compile erroron MSVC:
The bug is latent in the default build because without
MI_TRACK_ETW, the macro expands to nothing, so no statement isemitted and no semicolon is needed. It reproduces on VS2017/VS2019/VS2022 whenever ETW tracking is enabled.
Fix: add the missing
;terminator.