fix(bing-serp): do not rewrite result URLs that use their own u parameter - #2540
Open
Yutong Song (RainieLLM) wants to merge 2 commits into
Open
Yutong Song (RainieLLM) wants to merge 2 commits into
Yutong Song (RainieLLM) wants to merge 2 commits into
Conversation
…eter Bing puts each search result behind a /ck/a redirect link. The real destination sits in a base64 `u` query parameter, and the converter decodes it. The decoder did not check the link, so it decoded the `u` parameter of every <a href> in the result. A normal result that uses `u=` for its own purpose was therefore rewritten into garbage. Decode the `u` parameter only when the link is one that Bing wrapped.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BingSerpConverterdecoded theuquery parameter on every result link. As a result, a normal URL such ashttps://example.com/profile?u=abcdefcould become an invalid link.This change limits decoding to Bing's exact
/ck/apath onbing.comor its subdomains. Normal URLs and links with similar hosts or paths stay unchanged.Validation
raw.githubusercontent.comwas unavailable.main.