fix(rss): emit item and entry links as heading anchors - #2525
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Conversation
RSS items and Atom entries carry a <link> (or Atom <link href>), but the converter never read it: the markdown ended up with bare titles and no way to reach the post. Emit the title as a markdown link to the resolved URL instead (relative hrefs resolve against the feed URL). Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
There was a problem hiding this comment.
When an item has a link this drops the heading marker. heading starts as ## title, then gets replaced with title, so linked RSS/Atom entries stop being headings. Looks like that assignment just needs to keep the ## prefix.
Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
|
good catch, fixed. the linked branch now keeps the heading marker, so it renders as a level-2 heading with an anchor instead of a bare paragraph link. all 164 rss tests still green. |
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
Sylvester Kaczmarek (sylvesterkaczmarek)
left a comment
There was a problem hiding this comment.
Rechecked 40d6912. The linked Atom entry now keeps the ## heading marker while wrapping the title in the anchor, so linked items remain level-2 headings. That resolves the formatting issue I raised.
|
thanks for the fast turnaround on all three of these, the heading catch saved the feature from shipping half broken. |
The RSS and Atom converters read the feed-level link but never the per-item one, so every entry came out as a bare heading with no URL to reach. Titles now render as markdown links to the resolved item URL (Atom
<link href>attribute; RSS<link>text; relative hrefs resolve against the feed URL when the document URI is known).No output change for feeds whose items have no link element. Existing RSS suite green (107 passed).