fix(xlsx): keep integer rendering when blanks promote a column to float - #2524
Open
Frank_zhu (Frank-zhu0404) wants to merge 1 commit into
Open
Frank_zhu (Frank-zhu0404) wants to merge 1 commit into
Frank_zhu (Frank-zhu0404) wants to merge 1 commit into
Conversation
A single blank cell makes pandas read a numeric column as float64, so every whole number rendered as "1.0". Convert integral float columns back to ints before to_html for both .xlsx and .xls. Fixes microsoft#2484.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_html, so values like1no longer render as1.0when a blank cell promoted the column..xlsxand.xlsconverters.Fixes #2484.
Test plan
1.0/2.0); confirmed fixed output (1/2)pytest packages/markitdown/tests/test_xlsx_number_formatting.py— 5 passedtest_xlsx_images.py, showZeroes misc) — 25 passed