Skip to content

Fix Clippy warnings - #1468

Merged
Weiteng Chen (CvvT) merged 5 commits into
mainfrom
fix/clippy-assert-is-empty
Oct 1, 2026
Merged

Weiteng Chen (CvvT) merged 5 commits into
mainfrom
fix/clippy-assert-is-empty

Conversation

@CvvT

Copy link
Copy Markdown
Contributor

No description provided.

@CvvT
Weiteng Chen (CvvT) marked this pull request as ready for review October 1, 2026 20:06

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes overall seem mostly reasonable, but I think the RUSTFLAGS changes for the CI are problematic for downstream customers. We need to fix the underlying issue itself.

If it helps unblock things, a "cheaper" solution is to put an allow(deprecated) for the atomic fetch_update

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@jaybosamiya-ms

Copy link
Copy Markdown
Member

Something like 4629f4c from #1469 would act to unblock things

@CvvT

Copy link
Copy Markdown
Contributor Author

The changes overall seem mostly reasonable, but I think the RUSTFLAGS changes for the CI are problematic for downstream customers. We need to fix the underlying issue itself.

If it helps unblock things, a "cheaper" solution is to put an allow(deprecated) for the atomic fetch_update

I didn't use allow because in ulitebox there are ~15 functions using fetch_update. Let's see if we can bump the nightly version. If not, I agree it is better to use allow for now.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

🤖 SemverChecks 🤖 No breaking API changes detected

Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Weiteng!

@CvvT
Weiteng Chen (CvvT) added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit 17e3504 Oct 1, 2026
15 checks passed
@CvvT
Weiteng Chen (CvvT) deleted the fix/clippy-assert-is-empty branch October 1, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants