Add broker-coordinated child process startup - #1391
Merged
Merged
Conversation
Weidong Cui (wdcui)
force-pushed
the
wdcui/ulitebox/child-start
branch
from
September 19, 2026 01:39
04425be to
208ecda
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Converge child startup publication, acknowledgement, failure, shutdown, and finalization across Linux and Windows while preserving process identity safety. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Use one mutex-serialized std::process::Child lifecycle for Linux and Windows exit observation, termination, and final waiting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Replace the parallel startup-thread pin with explicit StartReady and StartCommitted process states completed after acknowledgement publication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Model every out-of-process runner with RunnerInstance and represent parent-issued startup through RunnerStartup and ProcessStart coordination. Move the process-start state machine into its own module and share one association-serving path across initial and started runners. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Name the module after RunnerProcessManager and represent each in-progress StartProcess operation as a transaction with explicit state. Clarify started-runner configuration and simplify the non-Linux exit-signal helper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Make StartProcess block until the new runner reports ready and broker startup completes. Remove acknowledgement tokens, receipt state, watchdog workers, and the intermediate committed process state while preserving bounded startup, teardown, and runner finalization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Allocate process and initial thread identities before launch, commit startup when the broker association activates, and remove the separate readiness protocol. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Weidong Cui (wdcui)
force-pushed
the
wdcui/ulitebox/child-start
branch
from
September 19, 2026 14:17
92daa2e to
0d730fb
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Launch the root and dynamically created processes through the same precreated broker process, deadline, association, supervision, and retirement path. Also resolve the related lifecycle review findings and remove the test shared-buffer leak. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Return the detailed runner completion error when root association startup fails, while retaining the broker failure as a safe fallback. Add regression coverage for a runner that exits before connecting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Update the macOS loader test to accept the optional process startup data returned by BrokerLocal negotiation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05547201-01e0-4ff2-87c6-27739e6cc816
Weidong Cui (wdcui)
enabled auto-merge
September 20, 2026 06:03
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds broker-coordinated dynamic child process startup for userland runners by introducing broker-owned process and thread identities, inherited object references, bounded startup data, and a portable process-launcher contract. Root and child runners use the same precreated-process negotiation, authenticated association, startup deadline, supervision, and retirement path across Linux and Windows, while parent requests synchronously receive the child identity after association activation and broker shutdown waits for all launched processes to finish.