Remove obsolete SSH tunnel protocol - #684
Merged
David Obando (DavidObando) merged 2 commits intoSep 22, 2026
Merged
Conversation
Remove the SSH value from the shared tunnel protocol contracts and regenerate the TypeScript, Go, Java, and Rust SDK surfaces. Stop requesting the retired SSH gateway public key when relay hosts update their endpoints. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 57ace76a-7df5-4dc5-b59f-1a4b8b239960
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
David Obando (DavidObando)
September 22, 2026 18:01
View session
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The central relay-host behavior change lacks direct regression coverage in both implementations.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Removes the obsolete SSH tunnel protocol while preserving legacy sshUser compatibility.
Changes:
- Removes SSH protocol constants across SDKs.
- Stops relay hosts requesting SSH gateway keys.
- Updates legacy SSH documentation.
| File | Description |
|---|---|
cs/src/Contracts/TunnelProtocol.cs |
Removes SSH constant. |
cs/src/Contracts/TunnelPort.cs |
Updates compatibility documentation. |
cs/src/Connections/TunnelRelayTunnelHost.cs |
Removes legacy SSH endpoint behavior. |
ts/src/contracts/tunnelProtocol.ts |
Removes generated SSH enum member. |
ts/src/contracts/tunnelPort.ts |
Updates compatibility documentation. |
ts/src/connections/tunnelRelayTunnelHost.ts |
Removes legacy SSH endpoint behavior. |
go/tunnels/tunnel_protocol.go |
Removes generated SSH constant. |
go/tunnels/tunnel_port.go |
Updates compatibility documentation. |
java/src/main/java/com/microsoft/tunnels/contracts/TunnelProtocol.java |
Removes generated SSH constant. |
java/src/main/java/com/microsoft/tunnels/contracts/TunnelPort.java |
Updates compatibility documentation. |
rs/src/contracts/tunnel_protocol.rs |
Removes generated SSH constant. |
rs/src/contracts/tunnel_port.rs |
Updates compatibility documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nagaraju Kotcharlakota (klvnraju)
previously approved these changes
Sep 22, 2026
Capture relay endpoint request options in the C# and TypeScript test clients and verify legacy SSH ports no longer request an SSH gateway key. Bump the Go SDK patch version for the contract API change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 57ace76a-7df5-4dc5-b59f-1a4b8b239960
David Obando (DavidObando)
enabled auto-merge (squash)
September 22, 2026 19:34
Nagaraju Kotcharlakota (klvnraju)
approved these changes
Sep 22, 2026
David Obando (DavidObando)
deleted the
davidobando/remove-tunnel-protocol-ssh
branch
September 22, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TunnelProtocol.Sshconstant from the C# contract and generated TypeScript, Go, Java, and Rust SDK surfacesincludeSshGatewayPublicKeyTunnelPort.SshUserand its existing serialization behavior for backward compatibilityValidation
dotnet build cs/TunnelsSDK.sln --no-incrementaldotnet test cs/test/TunnelsSDK.Test/TunnelsSDK.Test.csproj --no-build(144 passed)cd ts && npm run compilego test ./go/tunnels -run ^'$' && go test ./go/tunnels/ssh/...cd java && mvn package -q -DskipTestscd rs && cargo test(13 passed)The full Java test suite requires live integration-test configuration; packaging succeeds with the generated contract changes.