Feature/workshop feedback naming#18
Merged
Merged
Conversation
Feedback from the workshop run: - Rename the bundle naming token from mlops-workshop to databricks-mlops-workshop so job names, the workspace root_path and the MLflow experiment all match the repo. Also fix the training notebook's interactive experiment fallback, which pointed at a different path than the bundle-created experiment. - Rename the fraud_deployment_job bundle key to deployment_job (the fraud_ prefix did not match its resulting name). - Rename the metric_violation_check notebook and its task/widget/task-value keys to model_drift_check / is_model_drift_violated / model_drift_threshold. - Wrap generated TODO gaps in a banner with surrounding blank lines so they stand out from provided code.
… experiment - The ML schema resource key was ml_workspace while its name is fraud_ml; rename the key to fraud_ml so it matches, and update every \ reference plus the docs/comments in the sections touched. - Stop hard-coding the workshop name in the training notebook's interactive experiment fallback. Derive it from the notebook's own repo folder so it tracks the repo automatically; the DAB job still passes experiment_name explicitly.
…ndbox Shared/clean targets keep fraud_ml (alongside fraud_landing/bronze/silver/gold). The personal target overrides just the schema name to fraud, so development-mode prefixing gives each attendee a dev_<you>_fraud sandbox (not ML-specific). Drops the _ml suffix from every notebook's interactive per-user fallback and updates the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes workshop naming across notebooks, bundle resources, and documentation, including renaming the per-user/workspace schema conventions and reframing the “metric violation” retraining trigger as a “model drift” check.
Changes:
- Rename the personal dev schema fallback from
dev_<user>_fraud_mltodev_<user>_fraud, and rename the schema resource key fromml_workspacetofraud_ml(with personal-target override). - Rename the retraining trigger from
metric_violation_check/is_metric_violatedtomodel_drift_check/is_model_drift_violated, updating notebooks + workflow wiring + docs. - Update bundle/job naming to include
databricks-mlops-workshop, and improve visibility of generated TODO blocks (banner rules) insrc/.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/training/notebooks/training.py | Updates schema fallback name and changes interactive experiment-name fallback logic. |
| src/README.md | Updates monitoring stage description wording (“model drift”). |
| src/monitoring/README.md | Renames the listed retraining-check notebook to model_drift_check.py. |
| src/monitoring/notebooks/seed_drift.py | Updates schema fallback name to dev_<user>_fraud. |
| src/monitoring/notebooks/process_serving_logs.py | Updates schema fallback name; wraps TODO gap with banner rules. |
| src/monitoring/notebooks/monitoring.py | Updates schema fallback name; renames referenced notebook; wraps TODO gap with banner rules. |
| src/monitoring/notebooks/model_drift_check.py | Renames notebook semantics/outputs from metric violation to model drift task-value naming. |
| src/monitoring/notebooks/feature_drift_check.py | Updates cross-reference from metric violation check to model drift check. |
| src/feature_engineering/notebooks/build_features.py | Updates schema fallback name; wraps TODO gaps with banner rules. |
| src/deployment/model_deployment/notebooks/query_endpoint.py | Updates schema fallback name to dev_<user>_fraud. |
| src/deployment/model_deployment/notebooks/evaluation.py | Updates schema fallback name to dev_<user>_fraud. |
| src/deployment/model_deployment/notebooks/deployment.py | Updates schema fallback name to dev_<user>_fraud. |
| src/deployment/model_deployment/notebooks/approval.py | Updates schema fallback name to dev_<user>_fraud. |
| src/deployment/batch_inference/notebooks/batch_inference.py | Updates schema fallback name; wraps TODO gaps with banner rules. |
| solution/training/notebooks/training.py | Mirrors src/ training changes (schema + experiment fallback). |
| solution/README.md | Updates monitoring stage description wording (“model drift”). |
| solution/monitoring/README.md | Renames the listed retraining-check notebook to model_drift_check.py. |
| solution/monitoring/notebooks/seed_drift.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/monitoring/notebooks/process_serving_logs.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/monitoring/notebooks/monitoring.py | Updates schema fallback name; renames referenced notebook. |
| solution/monitoring/notebooks/model_drift_check.py | Mirrors task-value/widget naming changes for drift vs metric violation. |
| solution/monitoring/notebooks/feature_drift_check.py | Updates cross-reference from metric violation check to model drift check. |
| solution/feature_engineering/notebooks/build_features.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/deployment/model_deployment/notebooks/query_endpoint.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/deployment/model_deployment/notebooks/evaluation.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/deployment/model_deployment/notebooks/deployment.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/deployment/model_deployment/notebooks/approval.py | Updates schema fallback name to dev_<user>_fraud. |
| solution/deployment/batch_inference/notebooks/batch_inference.py | Updates schema fallback name to dev_<user>_fraud. |
| scripts/generate_src.py | Adds banner rules + spacing behavior to make generated TODO gaps more visually distinct. |
| resources/serving-log-processing-workflow.yml | Updates job name to include databricks-mlops-workshop. |
| resources/schemas-resource.yml | Renames schema resource key to fraud_ml and updates comments/semantics. |
| resources/README.md | Updates the schema resource description to reflect shared fraud_ml vs personal sandbox. |
| resources/monitoring-resource.yml | Rewires monitors and retraining job tasks to new schema resource key + model drift naming. |
| resources/model-training-workflow.yml | Updates job name and updates deployment job id reference to deployment_job. |
| resources/feature-engineering-workflow.yml | Updates job name to include databricks-mlops-workshop. |
| resources/deployment-job-workflow.yml | Renames job key to deployment_job and updates job name. |
| resources/data-ingestion-workflow.yml | Updates job name to include databricks-mlops-workshop. |
| resources/batch-inference-workflow.yml | Updates job name to include databricks-mlops-workshop. |
| README.md | Updates deployment-job name reference and updates schema explanation to fraud_ml/personal override model. |
| databricks.yml | Renames bundle, updates defaults/variable docs, adds personal schema override; updates prod workspace root_path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…t fallback Address PR review: staging.workspace.root_path still used /Workspace/mlops-workshop while prod used /Workspace/databricks-mlops-workshop; point both at databricks-mlops-workshop. Replace the fragile parents[3] notebook-path parsing (which broke on bundle deployment paths and defaulted to the old mlops-workshop name) with a simple experiment fallback under the user's home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.