fix: add support for macos in cert chain script - #143
fix: add support for macos in cert chain script#143Jesse Wright (jeswr) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to enable macOS compatibility for the certificate chain generation script.
- Updated directory path computations to work across Linux, Windows, and macOS
- Changed how scriptsdir and outdir are determined using realpath
Comments suppressed due to low confidence (1)
circuit_setup/scripts/gen_x509_cert_chain.sh:17
- The updated scriptsdir is set to an absolute path despite the comment stating that relative paths are to be used. Please verify if the intention is to use absolute paths on macOS and update the comment accordingly, or adjust the command to compute a relative path.
scriptsdir=$(realpath "$current_dir")
|
Thanks Jesse Wright (@jeswr). Does the rest of the build works on macOS? Specifically the |
|
I haven't tested those; and am going to be AFK for the next 3 days. Can test when I return |
|
I ran into the same issue on my macbook, and thanks to Jesse Wright (@jeswr) for the elegant solution here. I also ran crescent-credentials/creds/Cargo.toml Lines 66 to 69 in c639608 Also, to pass crescent-credentials/ecdsa-pop/Cargo.toml Lines 31 to 33 in c639608 |
Any recommended fix for the getrandom build failure? |
This gets the setup scripts working on a (my) macOS machine.
I have NOT tested this change on Linux and Windows - these changes should be tested on those environments before merging this PR.