Repository navigation

fix: prevent EDEADLK self-join in ~CurlHttpOperation on async-thread destruction - #1481

Closed

bmehta001 wants to merge 38 commits into

microsoft:mainfrom

bmehta001:bhamehta/fix-curl-async-self-join

Closed

fix: prevent EDEADLK self-join in ~CurlHttpOperation on async-thread destruction#1481
bmehta001 wants to merge 38 commits into
microsoft:mainfrom
bmehta001:bhamehta/fix-curl-async-self-join

Commits on Jun 10, 2026
- fix: guard HAVE_MAT_LIVEEVENTINSPECTOR/PRIVACYGUARD against redefinition
  
  bmehta001
  and
  Copilot
  committed
  7b43dd4
Commits on Jun 11, 2026
- fix: prevent EDEADLK self-join in ~CurlHttpOperation on async-thread destruction
  
  bmehta001
  and
  Copilot
  committed
  fc7375a
- Merge branch 'main' into bhamehta/fix-curl-async-self-join
  bmehta001
  authored
  e76fabf
Commits on Jun 13, 2026
- Make ~CurlHttpOperation detach conditional on self-join (fix UAF regression)
  
  bmehta001
  and
  Copilot
  committed
  3554d8d
- Address Copilot round 2 on #1481: include <new>, handle nothrow-new failure
  
  bmehta001
  and
  Copilot
  committed
  b10fa89
- Address Copilot round 3 on #1481: avoid atomic<thread::id>, fix lifetime comments
  
  bmehta001
  and
  Copilot
  committed
  3dda53b
- Address Copilot round 4 on #1481: precise self-join comment, reset flag on reuse
  
  bmehta001
  and
  Copilot
  committed
  7e22ed2
Commits on Jun 30, 2026
- Merge branch 'main' into bhamehta/fix-curl-async-self-join
  bmehta001
  authored
  dcbc2a2
Commits on Jul 8, 2026
Commits on Jul 9, 2026
- Address Copilot round 5 on #1481: <limits> include, broaden thread-start catch, fix test comment
  
  bmehta001
  and
  Copilot
  committed
  f9262e0
- Address Copilot round 6 on #1481: guard shared_from_this() in SendAsync
  
  bmehta001
  and
  Copilot
  committed
  a1da06f
- Correct the body-move comment in SendRequestAsync (#1481 review round 7)
  
  bmehta001
  and
  Copilot
  committed
  23b6f9a
- Harden NoSelfJoin test timeout path (#1481 review round 8)
  
  bmehta001
  and
  Copilot
  committed
  62395c7
- Move worker-lambda construction inside the try in SendAsync (#1481 review round 9)
  
  bmehta001
  and
  Copilot
  committed
  9ae7dd5
- Drop issue-number references from code comments
  
  bmehta001
  and
  Copilot
  committed
  1ff4b52
- Guarantee the callback fires even when Send() throws
  
  bmehta001
  and
  Copilot
  committed
  b1e03d8
Commits on Jul 10, 2026
- Fix use-after-free dispatching OnDestroy after the completion callback
  
  bmehta001
  and
  Copilot
  committed
  cf9bc95
- Address review: include <utility>, correct OnDestroy comment, harden test
  
  bmehta001
  and
  Copilot
  committed
  f2af5ec
- Fix two curl-client lifetime issues found in review
  
  bmehta001
  and
  Copilot
  committed
  4af8401
- Harden curl-client shutdown: complete-on-send and skip unsafe global cleanup
  
  bmehta001
  and
  Copilot
  committed
  89491fd
- Harden the completion-guard regression test against the timeout path
  
  bmehta001
  and
  Copilot
  committed
  9d69b19
- Clarify ~CurlHttpOperation comment for never-sent and synchronous-fallback cases
  
  bmehta001
  and
  Copilot
  committed
  bfabf8c
- Correct the OnDestroy comment: suppressed once a send is attempted
  
  bmehta001
  and
  Copilot
  committed
  e25c43c
- Wait for the operation to be destroyed in the self-join test's timeout path
  
  bmehta001
  and
  Copilot
  committed
  8e6575b
- Wait for the operation to be destroyed on the self-join test's success path
  
  bmehta001
  and
  Copilot
  committed
  d2c69dd
- Guarantee async ops are destroyed before teardown in both self-join tests
  
  bmehta001
  and
  Copilot
  committed
  8650ce1
- Hard-stop if a detached curl worker refuses to drain before teardown
  
  bmehta001
  and
  Copilot
  committed
  bd49de4
Commits on Jul 13, 2026
- Fix curl worker shutdown lifetime
  
  bmehta001
  and
  Copilot
  committed
  42d448c
Commits on Jul 30, 2026
- Simplify curl worker lifetime handling
  
  bmehta001
  and
  Copilot
  committed
  6b793ad
- Preserve curl completion semantics on worker failures
  
  bmehta001
  and
  Copilot
  committed
  88f5c8f
- Merge microsoft/main into the curl self-join fix
  
  bmehta001
  and
  Copilot
  committed
  48ad566
Commits on Aug 8, 2026
- Merge branch 'main' into bhamehta/fix-curl-async-self-join
  bmehta001
  authored
  85116f0

Commits

Commits on Jun 10, 2026

Commits on Jun 11, 2026

Commits on Jun 13, 2026

Commits on Jun 30, 2026

Commits on Jul 8, 2026

Commits on Jul 9, 2026

Commits on Jul 10, 2026

Commits on Jul 13, 2026

Commits on Jul 30, 2026

Commits on Aug 8, 2026