Logs info/default log messages to eclipse logs only if tracing is#25
Logs info/default log messages to eclipse logs only if tracing is#25raghucssit wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts how LSP4E window/logMessage events are forwarded to the Eclipse error log, so that Info/Log messages are only logged when LSP4E tracing is enabled (while still always logging Warning/Error).
Changes:
- Override
CopilotLanguageClient.logMessage(...)to suppressInfo/Logmessages unless tracing is enabled. - Introduce an LSP4E trace check via
Platform.getDebugBoolean("org.eclipse.lsp4e/trace").
|
It seems that we need to have a separate PR to bump the version: https://github.com/microsoft/copilot-for-eclipse/blob/main/base.target#L6 first. I will do it and verify that backward compatibility is fine after the bump. |
d322cf4 to
5c9f393
Compare
a771e33 to
17904c4
Compare
|
@jdneo I have added junit as well for the feature. It works as expected. Please start a build and see it we can get this merged. |
enabled. LSP4E by default logs info/default messages to Eclipse logs. But we want to log info only if tracing is enabled. see https://github.com/microsoft/copilot-eclipse-feedback/issues/185
17904c4 to
d5a95e9
Compare
|
@jdneo Please check this PR. This may be a good candidate to get into main soon.. |
|
@raghucssit: few things:
This error is coming because Copilot still uses too old LSP4E version. The "final" modifier was removed in LSP4E 0.28.0 release only, see:
@jdneo: would it be possible to bump Copilot lsp4e dependency from current 0.18.1 to 0.18.30 at least? This would also imply bump for lsp4j from 0.21.1 to 0.24.0 (at least). |
enabled.
LSP4E by default logs info/default messages to Eclipse logs. But we want to log info only if tracing is enabled.
see #121