This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Chart scaling - #804
Open
Ramil Minyukov (MrRamka) wants to merge 13 commits into
Open
Conversation
Ramil Minyukov (MrRamka)
commented
Oct 22, 2021
Ramil Minyukov (MrRamka)
commented
Collaborator
Ramil Minyukov (MrRamka)
marked this pull request as ready for review
October 25, 2021 16:34
| onGlyphContextMenuClick?: GlyphEventHandler; | ||
| renderEvents?: RenderEvents; | ||
|
|
||
| scale: number; |
There was a problem hiding this comment.
Are these fields (e.g., scale, viewWidth, viewHeight) required when serializing the chart component?
Collaborator
Author
There was a problem hiding this comment.
In this case, no. They are only needed to show chart
John Thompson (jrthompson33)
left a comment
John Thompson (jrthompson33)
left a comment
There was a problem hiding this comment.
Does the chart scaling need to be serialized when saving the chart?
Collaborator
Author
|
No, they are needed to view chart in visual |
John Thompson (jrthompson33)
approved these changes
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.