fix(SymCrypt-OpenSSL): disable KeysInUse - #18335
Merged
Merged
Conversation
KeysInUse lazily calls readlink() from an EC-key free path before checking whether logging is enabled. Setting enabled=0 therefore does not prevent the syscall. OpenSSH 10 blocks readlink in its pre-auth seccomp sandbox, killing sshd-auth with SIGSYS and dropping SSH connections when the provider is active. Compile KeysInUse out until initialization is sandbox-safe. Fixes: https://dev.azure.com/mariner-org/mariner/_workitems/edit/22827 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5f315f8d-6603-4659-8d14-4476bc265450
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables compile-time KeysInUse integration to prevent OpenSSH 10 pre-auth sandbox SIGSYS failures.
Changes:
- Removes
KEYSINUSE_ENABLED. - Documents the compatibility rationale.
- Refreshes rendered spec, release, changelog, and lock fingerprint.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
base/comps/SymCrypt-OpenSSL/SymCrypt-OpenSSL.spec |
Disables KeysInUse at build time. |
specs/s/SymCrypt-OpenSSL/SymCrypt-OpenSSL.spec |
Updates generated package output. |
locks/SymCrypt-OpenSSL.lock |
Refreshes the component fingerprint. |
christopherco
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable KeysInUse because its lazy
readlink()runs before the configuredenabledcheck and triggers SIGSYS in OpenSSH 10's pre-auth sandbox.AB#22827