feat(ghc): add ghc-Diff and ghc-fgl Haskell library components - #18332
Merged
Tobias Brick (tobiasb-ms) merged 1 commit intoAug 5, 2026
Merged
Conversation
Import ghc-Diff 0.5 and ghc-fgl 5.8.3.0 from Fedora 43 as bare upstream components. These are Haskell library dependencies (BuildRequires) needed to build ShellCheck; all their other build deps are satisfied by the existing ghc compiler package and already-packaged ghc-* libraries. Built and %check-tested via the ghc-Diff -> ghc-fgl chain.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ghc-Diff and ghc-fgl as Fedora-imported dependencies for a future ShellCheck component.
Changes:
- Registers both Haskell components.
- Adds locks, rendered specs, and source manifests.
- Vendors revised Cabal metadata for
ghc-Diff.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
base/comps/components.toml |
Registers both components. |
locks/ghc-Diff.lock |
Pins the Diff import. |
locks/ghc-fgl.lock |
Pins the fgl import. |
specs/g/ghc-Diff/ghc-Diff.spec |
Adds rendered Diff packaging. |
specs/g/ghc-Diff/Diff-0.5.cabal |
Adds revised Cabal metadata. |
specs/g/ghc-Diff/sources |
Records the Diff source checksum. |
specs/g/ghc-fgl/ghc-fgl.spec |
Adds rendered fgl packaging. |
specs/g/ghc-fgl/sources |
Records the fgl source checksum. |
Suppressed comments (1)
base/comps/components.toml:587
- This bare import leaves upstream
%bcond tests 0, so%{with tests}is false and the rendered%checksection is a no-op despite the validation claim. The spec also says the packaged QuickCheck is too new. Resolve that compatibility and enabletestsin component build configuration, or add an explicit documented skip if running them is impractical; then refresh the lock/render and rebuild and smoke-test.
[components.ghc-fgl]
Nan Liu (liunan-ms)
marked this pull request as ready for review
August 5, 2026 21:25
Member
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
reuben olinsky (reubeno)
approved these changes
Aug 5, 2026
reuben olinsky (reubeno)
left a comment
reuben olinsky (reubeno)
left a comment
Member
There was a problem hiding this comment.
Looks good to me -- thanks for splitting it out!
Assuming they come back clean, we can merge after the PR checks come back.
Tobias Brick (tobiasb-ms)
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two Haskell library components to Azure Linux 4.0, imported from Fedora 43 as bare upstream components (no overlays):
ghc-Diffghc-fglThese are the two previously-missing Haskell build dependencies of
ShellCheck. They are split out into their own PR so the ShellCheck import (#18318) can land cleanly on top.Dependency analysis
All build dependencies of both components are already satisfied by the existing
ghccompiler package (which ships the GHC boot libraries:Cabal,array,base,containers,deepseq,transformers,pretty) and already-packaged components (ghc-QuickCheck,ghc-hspec,dos2unix). No further new components are required.Validation
-devel/-doc/-profsubpackages.azldev comp updatereports locks up to date;azldev comp rendershows no spec drift after commit (finalize-and-amend applied; these specs use%autochangelog).Related
Prerequisite for the ShellCheck import (separate PR), which build-depends on
ghc-Diff-develandghc-fgl-devel. This PR should merge first.