fix(rasdaemon): update to 0.8.1 - #18324
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates rasdaemon to 0.8.1 ahead of Fedora.
Changes:
- Adds version and trigger-script overlays.
- Registers the 0.8.1 source tarball.
- Moves rasdaemon into a dedicated component definition.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
base/comps/rasdaemon/rasdaemon.comp.toml |
Defines source and packaging overlays. |
base/comps/components.toml |
Removes the former inline entry. |
locks/rasdaemon.lock |
Refreshes the component fingerprint. |
| lines = [ | ||
| "%{_sysconfdir}/ras/triggers/mc_event_trigger", | ||
| "%{_sysconfdir}/ras/triggers/mem_fail_trigger", | ||
| ] |
| description = "Bump rasdaemon to 0.8.1 (ahead of Fedora, which still ships 0.8.0)" | ||
| type = "spec-update-tag" | ||
| tag = "Version" | ||
| value = "0.8.1" |
422c315 to
834e960
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
base/comps/rasdaemon/rasdaemon.comp.toml:38
- This introduces the only plain-HTTP
source-filesdownload origin underbase/comps; existing entries use HTTPS. The official v0.8.1 release exposes this same named asset over HTTPS, so use that endpoint to avoid unauthenticated transport and HTTP-only availability failures.
origin = { type = "download", uri = "http://www.infradead.org/~mchehab/rasdaemon/rasdaemon-0.8.1.tar.bz2" }
base/comps/rasdaemon/rasdaemon.comp.toml:33
- This comment says the 0.8.0 tarball is pruned, but the rendered
specs/r/rasdaemon/sourcesretains both 0.8.0 and 0.8.1. Please describe the actual additive behavior so future cleanup does not assume the old source entry is already gone.
# Replaces the pruned 0.8.0 tarball once the Version overlay renders the new filename.
| @@ -0,0 +1,38 @@ | |||
| # rasdaemon — RAS (Reliability, Availability and Serviceability) error logging tool. | |||
| # | |||
| # Azure Linux carries rasdaemon 0.8.1, which is newer than the version Fedora | |||
There was a problem hiding this comment.
question(blocking): While we're open to package-level upgrades on a case-by-case basis, our default is presently to stick with what's in Fedora 43. The PR title says "fix"; is there a specific set of issues or use cases that you're looking to resolve with this upgrade? Some additional explanation/justification in the PR will better help us understand the trade-off.
There was a problem hiding this comment.
0.8.1 comes with a fix that allows for memory controller bank type decoding on dual-socket AMD systems.
| filename = "rasdaemon-0.8.1.tar.bz2" | ||
| hash = "65e478836f0e40fc4714af67ff2117771b7b2e06f94d99c2c952bd040dc3f130a93d4c9e44f3ae045c427fc69c5edd4a89d595243a8702fa98ab4ad2615d99fe" | ||
| hash-type = "SHA512" | ||
| origin = { type = "download", uri = "http://www.infradead.org/~mchehab/rasdaemon/rasdaemon-0.8.1.tar.bz2" } |
There was a problem hiding this comment.
issue(blocking): I know that this is one of the URLs listed in the spec, but I also see that https://github.com/mchehab/rasdaemon hosts release archives for rasdaemon (and is accessible via HTTPS). Assuming those archives match what we're looking for, I think we should switch over to them.
There was a problem hiding this comment.
Yep, i can change the URL to github, wanted to limit the spec file change as much as possible
| @@ -0,0 +1,38 @@ | |||
| # rasdaemon — RAS (Reliability, Availability and Serviceability) error logging tool. | |||
| # | |||
| # Azure Linux carries rasdaemon 0.8.1, which is newer than the version Fedora | |||
There was a problem hiding this comment.
question: Is there a specific reason you're recommending 0.8.1? If we are considering an upgrade -- that still appears to be ~2 years old.
There was a problem hiding this comment.
I picked the version that contains the fix needed for our site, happy to bump to the latest version.
Bump rasdaemon 0.8.0 -> 0.8.1 via overlay (ahead of Fedora, which still ships 0.8.0) and add the matching 0.8.1 source tarball. Package the new mc_event_trigger and mem_fail_trigger RAS trigger scripts shipped in 0.8.1. Move the component to a dedicated base/comps/rasdaemon/rasdaemon.comp.toml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
834e960 to
5835ca9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
base/comps/rasdaemon/rasdaemon.comp.toml:52
- This says the old tarball is pruned, but the rendered
specs/r/rasdaemon/sourcesstill contains both 0.8.0 and 0.8.1 because this differently namedsource-filesentry is additive. Update the comment so it accurately describes the generated state.
# Pristine upstream 0.8.1 release tarball from the maintainer's GitHub releases
# (matches the spec's %{name}-%{version} Source0). Replaces the pruned 0.8.0
# tarball once the Version overlay renders the new filename.
base/comps/rasdaemon/rasdaemon.comp.toml:14
- The version bump leaves the inherited 0.8.0
%configureallowlist unchanged. rasdaemon 0.8.1 adds--enable-cxl,--enable-yitian-ns-decode, and--enable-jaguar-ns-decode; since the rendered spec passes none of them, the corresponding 0.8.1 handlers are not compiled. Add a%buildoverlay enabling CXL and the architecture-appropriate Yitian/Jaguar handlers, or document why these capabilities must remain disabled.
value = "0.8.1"
Bump rasdaemon 0.8.0 -> 0.8.1 via overlay (ahead of Fedora, which still ships 0.8.0) and add the matching 0.8.1 source tarball. Package the new mc_event_trigger and mem_fail_trigger RAS trigger scripts shipped in 0.8.1. Move the component to a dedicated base/comps/rasdaemon/rasdaemon.comp.toml.