Repository navigation
fix(controller): fill configured local runner capacity - #624
Closed
Bluu (Bluuok) wants to merge 1 commit into
Closed
Bluu (Bluuok) wants to merge 1 commit into
Bluu (Bluuok) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation correctly addresses capacity underutilization and includes representative regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Updates local reconciliation to query enough active rollouts to utilize the configured worker pool.
Changes:
- Sets the query limit to at least the configured pool size while preserving the minimum of 50.
- Adds regression coverage for pool sizes 25, 50, 60, and 128.
| File | Description |
|---|---|
agentlightning/controller/local_reconciler.py |
Scales the rollout query limit with local capacity. |
tests/controller/test_local_reconciler.py |
Verifies query limits and pool utilization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
local_runner.maximum_size=60or128, the local controller still requests only 50 queuing/running rollouts. If those first 50 stay running, the remaining configured worker slots cannot be used and later queued work remains invisible.Size the query limit to at least the configured pool capacity, preserving the existing minimum/default of 50.
Validation on Ubuntu 24.04 / Python 3.12 with locked CPU dependencies:
python -m pytest -q tests/controller: 28 passed.No GPU training was run. This change is independent of terminal-process history cleanup in #618.
AI assistance was used to investigate, implement, and validate the fix. The final diff and regression behavior were reviewed before submission. The CLA check has passed; fork CI is awaiting maintainer approval.