Skip to content

Python: make optional Lightning observability test skip nested import errors #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
宇宙的山峰 (UniversePeak) wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Python: make optional Lightning observability test skip nested import errors #8071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/packages/lab/lightning/tests/test_lightning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ async def test_observability(workflow_two_agents: Workflow):
| |
[chat gpt-4o] [chat gpt-4o]
"""
pytest.importorskip("agentlightning")
# agentlightning imports optional proxy dependencies that may fail independently.
# Keep this optional observability test skippable when any such import is broken.
pytest.importorskip("agentlightning", exc_type=ImportError)
from agent_framework_lab_lightning import AgentFrameworkTracer
from agentlightning.adapter import TracerTraceToTriplet

Expand Down
Loading