[MRTCore] Add Microsoft.Windows.Globalization.ApplicationLanguages class - #4523
Merged
Keith Mahoney (kmahone) merged 13 commits intoJun 28, 2024
Merged
Conversation
Thread safe PrimaryLanguageOverride for un-packaged Use W.G.PrimaryLanguageOverride for packaged
Check if valid language tag is passed to PrimaryLanguageOverride
This reverts commit b273263.
Member
Author
|
/azp run |
Member
Author
|
/azp run |
|
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
1 similar comment
|
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hui Chen (huichen123)
approved these changes
Jun 28, 2024
Keith Mahoney (kmahone)
deleted the
user/kmahone/add_primary_language_override
branch
June 28, 2024 21:13
Contributor
|
Keith Mahoney (@kmahone) tnx for this great api, can we use it with next release? (v1.6-exp2 ?) |
Collaborator
|
Mahdi Hosseini (@ghost1372) Yes, this API is in the 1.6.240701003-experimental2 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A port of PR #4181
It looks like there are issues running the validation pipeline from forks, so porting the commits to a branch in this repo.
Changing the application language using PrimaryLanguageOverride property from
Windows.Globalization.ApplicationLanguagesnamespace is not supported for WindowsAppSDK unpackaged apps, only for packaged. To support language change for un-packaged applicationsMicrosoft.Windows.Globalization.ApplicationLanguages.ApplicationLanguagestype is introduced in MRTCore.Microsoft.Windows.Globalization.ApplicationLanguages.PrimaryLanguageOverrideproperty is supported both for packaged and un-packaged WindowsAppSDK apps.Sample app used to verify the change: https://github.com/stefansjfw/testwasdk/blob/master/testlocalwinappsdk/App.xaml.cs#L36