Repository navigation
aspnet: Fix server retry lifetime and Bombardier port propagation - #851
Merged
Merged
Conversation
Cancel and await each owned server lifetime before replacement so intentional shutdown cannot trigger stale retries. Preserve process diagnostics and standard workload failure handling for Kestrel and Orchard, and resolve Bombardier URLs from the configured server port. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Clarify serialized lifecycle calls, completion versus readiness, and cancellation-independent shutdown. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Erica Vellanoweth (ericavella)
approved these changes
Nov 9, 2026
AlexWFMS
enabled auto-merge (squash)
November 9, 2026 22:15
AlexWFMS
added a commit
that referenced
this pull request
Nov 9, 2026
Increment the patch version after the ASP.NET lifecycle fix in #851 so the updated framework and platform packages receive a new version. Co-authored-by: Alex Williams-Ferreira <alexwill@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stopping an ASP.NET server process did not cancel its background retry task. A previous iteration could restart its server and compete with the next iteration for port 9876, while the profile still emitted success and performance metrics.
Validation
Review notes
Windows affinity support is handled separately by #850; this branch does not include that fix, and combined integration testing is still pending.
Orchard HTTP timeouts occurred in both original and modified builds, including original-duration controls; this PR does not claim to resolve them. The newly included profile port wiring has functional-test coverage, not a new end-to-end Azure run.
Cleanup now targets only processes owned by the executor, rather than killing unrelated processes by image name or port.