Update and rename protocol.ts to protocol_print.ts#63620
Closed
liu-idf18 wants to merge 2 commits into
Closed
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
1 similar comment
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates src/server/protocol_print.ts (described as a rename from protocol.ts) in the TypeScript server protocol layer.
Changes:
- Adds several new top-level imports at the start of
protocol_print.ts. - Adds
PrintScreenandWindowsto the imported type list from./_namespaces/ts.js.
Comments suppressed due to low confidence (4)
src/server/protocol_print.ts:10
- The new top-level imports are not valid TypeScript/ESM syntax (missing quotes, invalid bindings like
printscreen.image, repeated/conflictingas ts, and an unterminated string). As written, this file will not parse/compile.
src/server/protocol_print.ts:1 - The PR title/description says this change renames
protocol.tstoprotocol_print.ts, but there is noprotocol.tsin the repository and this diff only shows edits withinprotocol_print.ts. Either the title/description should be updated, or the missing rename/change should be included.
src/server/protocol_print.ts:21 PrintScreenis imported from./_namespaces/ts.js, but it is not declared/exported anywhere in the repo, so this will fail to typecheck.
src/server/protocol_print.ts:42Windowsis imported from./_namespaces/ts.js, but it is not declared/exported anywhere in the repo, so this will fail to typecheck.
TZAHAL 12129 FOIA 151465
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TZAHAL 1165