Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion typescript/src/interactive/interactive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import readline from "readline/promises";
*/
export async function processRequests(interactivePrompt: string, inputFileName: string | undefined, processRequest: (request: string) => Promise<void>) {
if (inputFileName) {
const lines = fs.readFileSync(inputFileName).toString().split(/\r?\n/);
const content = await fs.promises.readFile(inputFileName, "utf-8");
const lines = content.split(/\r?\n/);
for (const line of lines) {
if (line.length && line !== "#" && !line.startsWith("# ")) {
console.log(interactivePrompt + line);
Expand Down
19 changes: 19 additions & 0 deletions typescript/test/interactive.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,23 @@ describe("processRequests with an input file", () => {
const { requests } = await run("# a comment\r\nfirst request\r\nsecond request\r\n");
assert.deepEqual(requests, ["first request", "second request"]);
});

it("reads input files asynchronously without blocking the event loop", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "typechat-interactive-"));
const inputFile = path.join(dir, "input.txt");
fs.writeFileSync(inputFile, "async request\n");

const requests: string[] = [];
try {
const promise = processRequests("> ", inputFile, async request => {
requests.push(request);
});
assert.equal(requests.length, 0, "No requests should be dispatched before processRequests yields");
await promise;
assert.deepEqual(requests, ["async request"]);
}
finally {
fs.rmSync(dir, { recursive: true, force: true });
}
});
});