Repository navigation
Fix offline candidate collection in coding checkouts - #522
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the offline candidate-collection fix.
No open issues 🎉
What changed in this PR
This PR fixes offline candidate collection in automation coding checkouts by including the root .gitignore before sandbox isolation. It addresses the infrastructure failure encountered during the build for #517 without implementing the Python multimodal feature.
Changes:
- Include
.gitignorein the sparse checkout and regenerate the locked workflow. - Add a regression test covering complete modified/added file contents and ignored dependency exclusion with an unavailable remote.
- Document why ignore rules must be available before isolation.
| File | Description |
|---|---|
tools/tests/implementation-workflow.test.mjs |
Adds offline partial-clone candidate collection regression coverage. |
AUTOMATION.md |
Explains why the checkout includes root ignore rules. |
.github/workflows/issue-implementation.md |
Adds .gitignore to the sparse checkout. |
.github/workflows/issue-implementation.lock.yml |
Updates the compiled checkout and generated metadata. |
Review effort: Balanced
Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix offline candidate collection by including the root
.gitignorein the trusted sparse coding checkout before sandbox isolation.Background
The build for #517 reached coding, but the collector's
git ls-files --others --exclude-standardattempted to lazily fetch the omitted root ignore blob. Certificate verification failed inside the sandbox, no candidate was produced, and independent checks/publication were skipped.Relates to #517. This fixes automation packaging only; it does not implement or close the Python multimodal feature request.
Validation
32ecafbc061c9af57e9361942099e381102ae304: succeeded with no warnings.git diff --check: passed.TLS verification, authorization, credentials, sandbox isolation, artifact limits, and spending reservations are unchanged. No additional paid implementation run was started.