Skip to content

Fix offline candidate collection in coding checkouts - #522

Merged
robgruen merged 3 commits into
mainfrom
fix/build-checkout-gitignore-517
Nov 5, 2026
Merged

robgruen merged 3 commits into
mainfrom
fix/build-checkout-gitignore-517

Conversation

@robgruen

@robgruen robgruen commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix offline candidate collection by including the root .gitignore in the trusted sparse coding checkout before sandbox isolation.

  • Regenerate the locked implementation workflow with the pinned compiler.
  • Add a deterministic regression using the actual authored/compiled checkout patterns, a blob-filtered partial clone, and an unavailable remote. Verify complete modified/added file contents while excluding ignored dependency files.
  • Document why ignore rules must be materialized before isolation.

Background

The build for #517 reached coding, but the collector's git ls-files --others --exclude-standard attempted to lazily fetch the omitted root ignore blob. Certificate verification failed inside the sandbox, no candidate was produced, and independent checks/publication were skipped.

Relates to #517. This fixes automation packaging only; it does not implement or close the Python multimodal feature request.

Validation

  • Reproduced the collector failure with the new offline partial-clone regression before the checkout fix; verified it passes afterward.
  • 115 focused workflow and collector tests passed on Node 24.22.1.
  • Strict compilation with pinned gh-aw v0.93.5 and action revision 32ecafbc061c9af57e9361942099e381102ae304: succeeded with no warnings.
  • git diff --check: passed.

TLS verification, authorization, credentials, sandbox isolation, artifact limits, and spending reservations are unchanged. No additional paid implementation run was started.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 5, 2026 21:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the offline candidate-collection fix.

No open issues 🎉

What changed in this PR

This PR fixes offline candidate collection in automation coding checkouts by including the root .gitignore before sandbox isolation. It addresses the infrastructure failure encountered during the build for #517 without implementing the Python multimodal feature.

Changes:

  • Include .gitignore in the sparse checkout and regenerate the locked workflow.
  • Add a regression test covering complete modified/added file contents and ignored dependency exclusion with an unavailable remote.
  • Document why ignore rules must be available before isolation.
File Description
tools/​tests/​implementation-workflow.test.mjs Adds offline partial-clone candidate collection regression coverage.
AUTOMATION.md Explains why the checkout includes root ignore rules.
.github/​workflows/​issue-implementation.md Adds .gitignore to the sparse checkout.
.github/​workflows/​issue-implementation.lock.yml Updates the compiled checkout and generated metadata.

Review effort: Balanced

Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 5, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the offline candidate-collection fix.

No open issues 🎉

Review effort: Balanced

Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 5, 2026 22:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the offline candidate-collection fix.

No open issues 🎉

Review effort: Balanced

@robgruen
robgruen merged commit 7823409 into main Nov 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants