Skip to content

Add public proposal rounds and versioned development commands - #520

Merged
robgruen merged 6 commits into
mainfrom
feature/public-proposal-workflow
Nov 4, 2026
Merged

robgruen merged 6 commits into
mainfrom
feature/public-proposal-workflow

Conversation

@robgruen

@robgruen robgruen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Make the normal owner workflow public and discussion-driven, without manual artifact-ID or hash lookup:

  • Use /typechat reply for one checked conversational response.
  • Use /typechat propose for numbered public Issue proposals that consider the complete frozen discussion and previous rounds, recommend a concrete approach, and explain what changed.
  • Use /typechat accept P<number> to approve an exact ready public version, then separately authorize /typechat build P<number> against its immutable accepted terms.
  • Preserve the optional legacy draft/publish and hash-based commands, owner-only authorization, validation and scanning, freshness checks, durable write intents, duplicate protection, and the default-off build gate.
  • Update the owner cheat sheet, automation policy, contributor guidance, and prompts; regenerate the affected workflow locks.

Validation

Validated after incorporating current main, including #515:

  • Repository automation suite on pinned Node.js 24.22.1: 371 passed, 0 failed, 1 opt-in sandbox integration test skipped.
  • Pinned gh-aw v0.93.5 strict compilation: 3 workflows compiled, 0 warnings.
  • Repeated compilation produced no generated-file drift.
  • Whitespace checks passed.

Regression coverage includes repeated public rounds, full discussion context, exact-version acceptance despite newer proposals, immutable visible terms, edited/stale/expired/ambiguous evidence, publication races, duplicate writes, legacy compatibility, and an accepted-version-to-PR lifecycle.

Rollout

The new public-proposal/version-selector paths are not yet live-verified. Controlled owner-commanded verification follows merge. This change does not enable TYPECHAT_IMPLEMENTATION_ENABLED, start a coding run, automatically accept work, or approve merging.

Post iterative public recommendations and accept/build exact proposal versions without manual artifact or hash lookup. Preserve legacy commands, owner authorization, scanning, and publication safeguards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A writer-only recovery can publish an acceptance-enabled proposal using a failed attempt’s seal, but acceptance then rejects it; this path needs a fix and regression coverage through acceptance.

1 open issue
What changed in this PR

Adds public, versioned proposals to TypeChat’s owner-controlled automation, allowing discussion, acceptance, and separately authorized builds without manual artifact or hash lookup. The new paths remain pending live verification, and build activation stays default-off.

Changes:

  • Adds /typechat propose, /typechat accept P<number>, and /typechat build P<number> while retaining legacy commands.
  • Extends validation, publication safeguards, and regression coverage for public proposal rounds.
  • Updates workflow prompts, generated locks, and owner/contributor documentation.
File Description
tools/​tests/​issue-implementation.test.mjs Tests version-selected builds and immutable accepted terms.
tools/​tests/​discussion-workflows.test.mjs Tests Issue-only proposal routing and publication guards.
tools/​tests/​discussion-draft.test.mjs Covers proposal rounds, acceptance, freshness, and duplicate protection.
tools/​issue-implementation.mjs Resolves public versions to exact accepted work.
tools/​discussion-draft.mjs Implements proposal rendering, versioning, and acceptance verification.
README.md Introduces the public proposal flow and rollout status.
OWNER-CHEATSHEET.md Documents version-based commands and recovery guidance.
AUTOMATION.md Defines proposal rounds, safeguards, and rollout boundaries.
.github/​workflows/​issue-implementation.md Updates the workflow description for public-version builds.
.github/​workflows/​issue-implementation.lock.yml Regenerates implementation workflow metadata and descriptions.
.github/​workflows/​discussion-draft.md Adds proposal routing, scan handling, and generation instructions.
.github/​workflows/​discussion-draft.lock.yml Regenerates proposal-enabled workflow configuration.
.github/​copilot-instructions.md Aligns contributor guidance with public proposal rounds.

Review effort: Balanced

Comment thread tools/discussion-draft.mjs Resolved
Keep original producer verification strict instead of advertising acceptance after a writer-only recovery of a failed seal. Cover fresh proposal recovery through acceptance and preserve advisory reply/proposal recovery; document the supported recovery path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved proposal writes can be missed when the original command comment is edited or deleted, allowing a new round to reuse P1 while the earlier write remains unresolved.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread tools/discussion-draft.mjs Resolved
Key pending proposal writes by immutable repository and Issue Node IDs plus the public version instead of rescanning mutable command comments. Retain the original command snapshot, block edited/deleted-command bypasses, and permit confirmed history to advance.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 21:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues
1 resolved since last review

Review effort: Lite

Comment thread tools/discussion-draft.mjs Resolved
Comment thread tools/discussion-draft.mjs Resolved
Comment thread tools/discussion-draft.mjs Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 4, 2026 00:13
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Changes to the proposal-to-acceptance protocol and privileged build authorization remain unverified in live workflows, requiring owner review and controlled verification before rollout.

1 open issue
2 resolved since last review

Review effort: Balanced

Pass already-parsed accepted terms to visible proposal verification, extract fields by heading, and share the existing Markdown decoder. Preserve canonical record and integrity validation while covering formatting changes, semantic differences, and ambiguous or hidden fields.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 4, 2026 00:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Authorization-critical publication and owner-acceptance paths still await controlled owner-commanded end-to-end verification and human review of GitHub Actions permissions, handoffs, and recovery behavior.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@robgruen
robgruen merged commit 32101a2 into main Nov 4, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants