Skip to content

Serialize Pages deployments and isolate retry artifacts - #512

Merged
robgruen merged 1 commit into
mainfrom
dev/robgruen/pages-deployment-retries
Nov 2, 2026
Merged

robgruen merged 1 commit into
mainfrom
dev/robgruen/pages-deployment-retries

Conversation

@robgruen

@robgruen robgruen commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix the two Pages deployment failures observed after the recent merges:

  • Attempt 1 of run 41508525457 collided with the preceding deployment, which was still publishing.
  • The owner-approved attempt 2 found two retained artifacts named github-pages and refused ambiguous selection.

Changes

  • Serialize the workflow in the shared pages concurrency group without cancelling an active publish.
  • Upload and deploy the same github-pages-${{ github.run_attempt }} artifact. Artifact lookup is scoped to the current workflow run, and retained earlier attempts have distinct names.
  • Add focused regression tests and operator guidance about safe retries and their original workflow versions.

Permissions, the main-only trigger, action pins, Node selection, and the site build commands are unchanged. No artifact deletion or coding-pilot activation is introduced.

Validation

  • The old workflow failed the concurrency and attempt-isolation regressions; its permission/trigger test passed.
  • All three focused tests pass after the change on Node 24.22.1, including exact artifact selection across three retained attempts.
  • YAML parsing and whitespace checks pass. The tests are automatically included in the existing repository-automation CI suite.
  • All 14 current-head CI checks pass, including the full repository-automation check, aggregate CodeQL, and isolated-container smoke test. Copilot reports no open issues and recommends approval; human review and merge remain separate decisions.
  • No new live deployment is claimed before review and merge.

Rollout

The updated documentation is already live from the preceding successful deployment. After this PR is reviewed and merged, follow the new default-branch Pages run; rerunning the old failure would still use its old workflow definition. The existing failed run and its artifacts have been preserved. No automatic merge or further coding/detection run is requested.

Queue Pages publishes without cancelling an active deployment. Match upload and deployment to an attempt-specific artifact name so retained earlier attempts cannot make selection ambiguous. Add regression tests and operator recovery guidance without changing permissions or action pins.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the changes addressing Pages deployment collisions and retry artifact selection.

No open issues 🎉

What changed in this PR

This PR addresses Pages deployment collisions and ambiguous artifact selection on retries, while preserving the existing trigger, permissions, action pins, and build steps.

Changes:

  • Serializes deployments in the shared pages concurrency group without cancelling an active publish.
  • Uses matching attempt-specific names for uploaded and deployed artifacts.
  • Adds focused regression tests and operator guidance for safe retries.
File Description
tools/​tests/​pages-workflow.test.mjs Tests concurrency, retry artifact isolation, and preserved workflow safeguards.
OWNER-CHEATSHEET.md Documents deployment behavior and safe retries using the original workflow version.
.github/​workflows/​github-pages.yml Adds deployment concurrency and matching attempt-specific artifact names.

Review effort: Balanced

@robgruen
robgruen merged commit fd25d44 into main Nov 2, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants