Repository navigation
Reject failed agent outputs before sealing discussion replies - #499
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change that restricts artifact sealing to exclusively noop collector output.
No open issues 🎉
What changed in this PR
This PR closes the failure-handling gap identified in #498 by requiring the trusted collector’s output types to be exactly noop before sealing a discussion-response artifact. This protects both Issue and Discussion replies without waiting for the later conclusion job.
Changes:
- Reject missing, unknown, incomplete, failure, and mixed output types before rendering or sealing.
- Add regression coverage across draft and direct-reply modes, including authored/generated workflow consistency.
- Document the sealing gate while preserving existing authorization and publication controls.
| File | Description |
|---|---|
tools/tests/discussion-workflows.test.mjs |
Checks collector-output wiring, generated parity, and writer seal prerequisites. |
tools/tests/discussion-draft.test.mjs |
Tests rejection of invalid completion signals across Issue and Discussion modes. |
AUTOMATION.md |
Documents the completion gate and protection against publication races. |
.github/workflows/discussion-draft.md |
Requires an exclusive noop output before sealing. |
.github/workflows/discussion-draft.lock.yml |
Includes the compiled gate and updated workflow metadata. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the unresolved review comment in #498: #498 (comment).
The direct reply writers can run before the final conclusion job records a model failure. Require the trusted collector's output types to be exactly
noopin the shared sealing step, before rendering or creating a publishable artifact.report_missing_data,report_incomplete, mixed completion/failure reports, and missing or unknown output types—even with a valid candidate and a successful scan.Validation
No live model run or public response was triggered. Human review and merge are still required.