Repository navigation
fix: build the root package before workspaces - #474
Conversation
# Conflicts: # typescript/package.json
There was a problem hiding this comment.
🟡 Changes recommended
The package test mishandles paths containing spaces on Windows and requires fresh registry downloads on every run, causing failures before validation in affected or offline environments.
2 open issues
What changed in this PR
This PR addresses #464 by building TypeChat’s root TypeScript package before its workspaces, preventing stale validator output from being packaged.
Changes:
- Update
build-allto compile the root package first. - Add a default-suite integration test that builds without generated output, packs the package, and checks accepted and rejected values in a clean TypeScript 7 consumer.
| File | Description |
|---|---|
typescript/tests/package.test.mjs |
Adds packaged-validator verification in an isolated consumer. |
typescript/package.json |
Fixes build order and includes the packaging test in npm test. |
Review effort: Balanced
|
Validation note: |


preparerunsbuild-all, but the script only compiled workspaces. npm excludes the root package from workspace runs, so the TypeScript validator's publisheddistcould remain stale and fail at runtime with the declared TypeScript 7 peer.Build the root package before workspaces. Add an integration test that builds from a source copy with no generated output, packs it, and verifies successful and rejected values in a clean TypeScript 7 consumer.
Validation:
npm ci --no-audit --no-fundnpm run build-allnpm test(178 tests passed)Fixes #464
Issue: #464