You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Support inline # comments on TypedDict and dataclass fields - #364
Uses inspect.getsourcelines + ast to pull # comments off field definitions at schema-generation time. Annotated/Doc still takes priority when both are present. Fails silently for dynamically-defined types (REPL, exec, etc.) so nothing breaks.
Adds three snapshot tests covering TypedDict inline comments, Doc-takes-priority, and dataclass inline comments.
…crosoft#242)
When no Annotated[..., Doc(...)] is present, fall back to the inline
# comment on the field's source line. Uses inspect + ast to extract
comments at class-definition time; fails silently so dynamic/REPL-
defined types are unaffected. Doc annotation still takes priority.
Hemanth Dhanasekaran (@hemanth1999k) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.
Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.
Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.
The reason will be displayed to describe this comment to others. Learn more.
I really like the idea of this PR. Having inline comments would be fantastic. However, I noted a few different schemas that could break the implementation as provided. Instead of doing a find string, use the Python tokenizer to get each raw AST token and then grab the contents of the comment token.
Here's a suggestion from copilot (requires importing io & tokenize):
def_extract_inline_field_comments(py_type: type) ->dict[str, str]:
"""Return a mapping of field name -> trailing '#' comment for a TypedDict/dataclass."""try:
source_lines, _=inspect.getsourcelines(py_type)
except (OSError, TypeError):
# Source unavailable (e.g. dynamically created types) -> no comments.return {}
source=textwrap.dedent("".join(source_lines))
# Only real COMMENT tokens count. A '#' inside "..." is a STRING token, so it's ignored.comment_by_line: dict[int, str] = {}
try:
fortokenintokenize.generate_tokens(io.StringIO(source).readline):
iftoken.type==tokenize.COMMENT:
comment_by_line[token.start[0]] =token.string[1:].strip()
except (tokenize.TokenError, IndentationError):
pass# keep whatever we gathered before an incomplete-source errorifnotcomment_by_line:
return {}
try:
tree=ast.parse(source)
exceptSyntaxError:
return {}
comments: dict[str, str] = {}
fornodeinast.walk(tree):
ifisinstance(node, ast.ClassDef):
forstmtinnode.body:
if (
isinstance(stmt, ast.AnnAssign)
andisinstance(stmt.target, ast.Name)
andstmt.end_linenoisnotNone
):
comment=comment_by_line.get(stmt.end_lineno)
ifcomment:
comments[stmt.target.id] =commentreturncomments
Merge current main while preserving the original contribution. Restrict comment extraction to the inspected class, preserve explicit documentation precedence, distinguish unavailable source from conversion errors, and exclude type-ignore directives. Add regression coverage and document source-inspection behavior.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Thanks for getting this started, Hemanth Dhanasekaran (@hemanth1999k)! We're going to pick up this feature and continue the work in this PR, preserving your contribution and credit.
Parse nested class fragments inside an outer suite rather than dedenting string contents. Keep AST and token coordinates aligned and cover multiline defaults, Literal annotations, docstrings, and invalid source outside the class.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Comments for name-mangled fields are omitted from generated documentation because their comment keys do not match the stored TypedDict and dataclass field names.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Mangle private field names before storing documentation keys
For a field such as __value, Python stores the annotation and dataclass field under a mangled name (e.g. _Point__value), but ast.Name.id remains __value. Both property-generation loops therefore miss this comment and emit no documentation, unlike the equivalent Annotated documentation. Apply class-name mangling before storing the comment key so these fields work for both TypedDicts and dataclasses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242.
Currently the only way to document a field is the verbose
Annotated[int, Doc("...")]syntax. This adds support for native Python inline comments:which produces the same TypeScript as before:
Uses
inspect.getsourcelines+astto pull# commentsoff field definitions at schema-generation time.Annotated/Docstill takes priority when both are present. Fails silently for dynamically-defined types (REPL,exec, etc.) so nothing breaks.Adds three snapshot tests covering TypedDict inline comments, Doc-takes-priority, and dataclass inline comments.