Fix poster figure shrinkage during HTML backfill - #40
Open
LingAo Xiao (ArmandXiao) wants to merge 1 commit into
Open
Fix poster figure shrinkage during HTML backfill#40LingAo Xiao (ArmandXiao) wants to merge 1 commit into
LingAo Xiao (ArmandXiao) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #37 fixed the durable HTML reload path, but it also froze Arial to DejaVu Sans before the expand baseline was captured. On the real MSRA 117 poster, that metric change reflowed the layout and reduced a figure from 95.20% fill to 79.16%. The later validator saw only the already-shrunken 79.16% baseline, so it could not detect the regression.
With bundled Arimo, the same four figures render at 95.18%, 95.25%, 95.25%, and 95.25%.
Validation
python -m py_compilepassed for the modified Python modulesgit diff --checkpassedverify-finalchecks passed95.20% -> 79.16%and exited 2PR hygiene
This PR contains only production code, skill documentation, and the OFL-licensed Arimo font assets. Test scripts, screenshots, logs, and audit results are intentionally not included.