Repository navigation
FEAT: Delete saved registry entries (part 20) - #4071
Open
varunj-msft wants to merge 238 commits into
Open
varunj-msft wants to merge 238 commits into
varunj-msft wants to merge 238 commits into
Conversation
…API input External construction now rejects a parameter whose type includes Path unless the calling service passes the name in allowed_path_params after making the value safe. The converter service allows its upload parameters once they are stored, and the target service allows the server-set upload folder and the GitHubCopilotTarget working directory. The scorer-only check is removed, and the "Valid parameters" list leaves out path parameters callers cannot set.
The target catalog now applies the path rule to required parameters too, so a target that needs a disallowed path is left out instead of listed without the field, matching the scorer catalog. allowed_path_params is typed frozenset[str] so a bare string cannot turn the allow-list into a substring match.
The target catalog still lists a target whose required path parameter is its server-set upload folder when the server has one, and leaves it out otherwise.
DELETE /api/scenario-presets/{name} and /api/scenario-suites/{name} accept an
optional ?expected_version= query. When supplied, the delete is refused with 409
if the stored document changed after the caller read it, so confirming a delete
in the GUI cannot discard an edit the caller never saw. Without it the delete
stays unconditional, preserving existing callers.
Locally the version is compared inside the existing per-document lock; on Azure
Blob the delete carries the read ETag with MatchConditions.IfNotModified. A
versioned delete of a document that is already gone still reports 404.
The preset and suite libraries send the version they loaded and, on 409, close
the confirmation, reload, and explain that the item changed.
Follow-up to review feedback on microsoft#3057.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
# Conflicts: # tests/unit/backend/test_converter_service.py
…benchmark's recipes folder
The OpenAI SDK adds that variable's headers to every request, so a saved OpenAI target would send whatever the server puts there, which can be a credential. While it's set, saving an OpenAI target is refused and a saved one isn't restored; the message names the variable, never its value. Targets declare such variables in server_header_variables.
Saving converters and scorers follows the same rules as saving targets now: a type that only a scan's launch script added can't be saved, a class without cached metadata is checked the way restore checks it, only a taken name is reported as a conflict, a storage failure logs its short reason, and the owner is recorded only when the entry is saved.
Saving a technique follows the same rules as the other saved entries now: an attack type that only a scan's launch script added can't be saved, a name or tag clash while registering is a conflict, and the owner is recorded only when the technique is saved. A held technique name is refused when a technique is checked before saving too.
… that the runtime stays ready
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is one of the changes for saving Registry entries across restarts. It needs #3965 (the list of entries that couldn't be restored, and Retry) and #3656 (version-checked deletes). Until the earlier PRs merge, the diff here also shows their changes.
A saved target, converter, scorer or technique couldn't be deleted from the app. The only way was to delete its file under
registry_recipes_sourceand restart, even for an entry that failed to restore and kept the backend from being ready.GET /api/saved-entries/{kind}/{name}describes a saved file: its version, why it can't be used if it can't, who saved it, and whether you may change it.DELETE /api/saved-entries/{kind}/{name}?expected_version=<version>deletes the file and removes the entry it restored.kindistargets,converters,scorersortechniques.DELETE /api/targets/{name}in FEAT: Support personal tokens with per-caller target credentials #4024, which removes Temporary targets under its own rules.DELETE /api/converters/{id}still refuses a saved converter (409), and its message points to the new route.What stays the same: saving and restoring work as before, except that a save waits for a delete in progress and checks again that what it names still comes back.
DELETE /api/converters/{id}still removes Temporary and startup converters from the live registry. Startup entries have no saved file, so they can't be deleted here (404).Screenshots: Delete on a saved target in the Targets table, the dialog, and the restore banner with Delete on each entry, including the dialog for an entry someone else saved.
Not covered: