Repository navigation
FEAT: Save targets created through the API (part 8) #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
varunj-msft
wants to merge
155
commits into
microsoft:main
Choose a base branch
from
varunj-msft:varunj-msft/13178-Save-Targets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
155 commits
Select commit
Hold shift + click to select a range
f36db28
FIX: Reject path parameters by default when building components from …
varunj-msft 291c462
Leave out target types that require a path callers may not set
varunj-msft 797831b
Test a target whose required path is the server upload folder
varunj-msft 214a0fa
Merge origin/main
varunj-msft 521ec7e
TEST: Cover saved converter copies in the server path check
varunj-msft 66fd155
FEAT: Report the documents a storage listing cannot use
varunj-msft 2d8c465
Report non-files and missing containers instead of skipping them
varunj-msft 5dec828
Report an entry that can't be checked instead of failing the whole li…
varunj-msft bf662b7
FEAT: Read saved registry recipes
varunj-msft e8b0604
Merge the server path check for API input
varunj-msft 9143ea6
FEAT: Rebuild saved registry entries in dependency order
varunj-msft c29d812
FEAT: Restore saved registry entries and stay not ready if any fail
varunj-msft cfa4fc0
Limit technique descriptions like the create request and export the r…
varunj-msft 33735f1
Merge the recipe model limits and exports
varunj-msft 11d0519
Keep restore failure messages safe and complete, and check technique …
varunj-msft 8ab7116
Merge the restore message and credential fixes
varunj-msft b7bf012
Document the recipes setting in the example config and pin the restor…
varunj-msft e45865b
Test that a description at the limit is accepted
varunj-msft b6927a9
Merge the description limit test
varunj-msft c94ffbd
Show only the error type when a URL in it may carry credentials
varunj-msft ac849a9
Merge the safer failure messages
varunj-msft 26377ea
Point the restore message at where failures are listed and guard the …
varunj-msft 8663852
Cut failure messages at any URL query or fragment and hide any with u…
varunj-msft 4159905
Merge the stricter failure messages
varunj-msft 9a419b4
Escape text that isn't UTF-8 in restore reports so they can be sent a…
varunj-msft 8fb8095
Merge the report text escaping
varunj-msft 9a67367
Read error text as plain normalized text and say when part of it is h…
varunj-msft 82c957f
Merge the plain, normalized failure text
varunj-msft 274b4ce
Escape entry names in restore reports too
varunj-msft 95f9492
Merge the entry name escaping
varunj-msft a60323a
Show error text with its original characters
varunj-msft e7558a4
Test that a reference name that isn't valid text can still be reported
varunj-msft 0e8490c
Merge the original-character error text and escaped entry names
varunj-msft 686d475
Test that the runtime status can report a reference name that isn't v…
varunj-msft c391b0d
Escape report text only when it is sent as JSON
varunj-msft 0b44db6
Merge the JSON-only report escaping
varunj-msft f986da5
Check each character on its own so long error messages stay fast
varunj-msft 807a904
Merge the per-character check and JSON-only report escaping
varunj-msft c86bfe6
Check the exact message for every form of each mark and bound the wor…
varunj-msft 454d05b
Merge the exact look-alike message checks
varunj-msft 9f91282
Test that the runtime status can list a file name that isn't valid text
varunj-msft a455494
Pass the look-alike check's arguments by keyword
varunj-msft ce8b684
Test that a technique waits for a saved converter in either list and …
varunj-msft d48a12c
Merge the converter-list and attack-type tests
varunj-msft 74412fe
Test that restore runs after the startup scripts, at startup and on a…
varunj-msft 784cd45
Keep the offline browser fixture away from saved registry entries
varunj-msft 507567b
Check the opened file before reading it and skip links deleted since …
varunj-msft 9d37ba3
Merge the opened-file check
varunj-msft ff2c836
Merge the opened-file check
varunj-msft 3afdcaa
Merge origin/main
varunj-msft de2f4e3
Let restore set the path parameters a target lets callers set, as the…
varunj-msft e821e7e
Merge the opened-file check, main and the caller path parameters
varunj-msft a45ac23
Close a file that isn't regular before reporting it and report entrie…
varunj-msft 60477e8
Merge the file handle fix
varunj-msft 28f2262
Merge the file handle fix
varunj-msft ad21f0c
Give only targets the path parameters their class lets callers set
varunj-msft 3dc4768
Merge the file handle fix and the target-only caller paths
varunj-msft db245dc
Test a file replaced just before it's opened and stop a blocked read …
varunj-msft 5d3d2d0
Merge the opened-file tests
varunj-msft 07a617f
Merge the opened-file tests
varunj-msft 2b4f1cc
Merge the opened-file tests
varunj-msft 80754a2
Read saved recipes separately from building them
varunj-msft 7965020
Merge the separate recipe read
varunj-msft bd84ef0
Build restored entries on the runtime loop and read them in a worker …
varunj-msft 1a192f7
Show every signed-in user why saved registry entries couldn't be rest…
varunj-msft 4fb7f35
Retry restoring saved registry entries without a restart
varunj-msft 27ef572
Drop a late retry answer when the runtime failed again between polls
varunj-msft fa1ae56
Keep Retry in reach and say when the failure list couldn't be loaded
varunj-msft 1af1d00
Stop a scan whose launch scripts would replace a saved entry
varunj-msft 17d6fe0
Report a saved-entry clash when a launch script wraps the refusal
varunj-msft b829bb8
Merge origin/main
varunj-msft a230568
Refuse saved targets that would authenticate with a key
varunj-msft 232857e
Check where saved targets send requests
varunj-msft 034522d
Accept only plain addresses and paths as saved target destinations
varunj-msft d10f3cf
Save targets created through the API
varunj-msft 0cbed4c
Count targets that a restart doesn't bring back as Temporary
varunj-msft d1bdd82
List presets, suites, and initializers through the checked listing
varunj-msft f5ed760
Merge the shared document listing
varunj-msft 4b55b17
Merge the shared document listing
varunj-msft a1866d5
Merge the shared document listing
varunj-msft e8dc897
Merge the shared document listing
varunj-msft 09a98af
Merge the shared document listing
varunj-msft 5ce5bb9
Merge the shared document listing
varunj-msft 84ac7c2
Merge the shared document listing
varunj-msft 76dbf9c
Report a preset, suite, or initializer folder that can't be read as u…
varunj-msft f823e4b
Merge the storage error mapping for unreadable folders
varunj-msft 99da684
Merge the storage error mapping for unreadable folders
varunj-msft 2c58145
Merge the storage error mapping for unreadable folders
varunj-msft 5a0afa6
Merge the storage error mapping for unreadable folders
varunj-msft 6bb9aec
Merge the storage error mapping for unreadable folders
varunj-msft a4790e9
Merge the storage error mapping for unreadable folders
varunj-msft 35ed34c
Merge the storage error mapping for unreadable folders
varunj-msft d70837c
Test each saved target URL rule on its own
varunj-msft 4ce3214
Describe what a saved target can use more precisely
varunj-msft 5669748
Merge the saved target rule tests and doc
varunj-msft 1ef0838
Describe saving targets more precisely
varunj-msft b3b8ac5
Test the remaining saved target URL rules on their own
varunj-msft 8a44952
Say which saved target addresses are checked
varunj-msft 14125fc
Merge the remaining saved target rule tests and doc
varunj-msft 078dc72
Describe what saving a target refuses more precisely
varunj-msft 6800d15
Merge origin/main
varunj-msft 74839cd
Merge origin/main
varunj-msft ee3e64f
Merge origin/main
varunj-msft 15e7a9e
Take out the restore retry changes merged here by mistake
varunj-msft 368b914
Merge origin/main
varunj-msft fd7bd4a
Merge origin/main
varunj-msft 844a424
Say a Temporary target is also gone after a reinitialization
varunj-msft 7d9ac2f
Log why storage is unavailable, without its path or URL
varunj-msft 7b5bfeb
Merge the storage error logging
varunj-msft 22806d8
Merge the storage error logging
varunj-msft 34011c9
Hide a restore message with a percent escape, which can hide a creden…
varunj-msft 8a0113f
Merge the storage error logging and the percent-escape fix
varunj-msft 8d51b6c
Merge the storage error logging and the percent-escape fix
varunj-msft 6ddd960
Merge the storage error logging and the percent-escape fix
varunj-msft 91bb36b
Merge the storage error logging and the percent-escape fix
varunj-msft dc4125c
Stop a launch whose script catches the duplicate-name error for a sav…
varunj-msft febc8c3
Merge the duplicate-name refusal for saved entries
varunj-msft 303dfa8
Merge the duplicate-name refusal for saved entries
varunj-msft e03fd18
Merge origin/main
varunj-msft 36462db
Merge origin/main
varunj-msft 031dc61
Merge origin/main
varunj-msft 7f8ab0d
Merge origin/main
varunj-msft 19205b1
Import the saved recipe models from their package, as main now requires
varunj-msft 0348a0b
Merge origin/main
varunj-msft bba3afd
Import from public packages, as main now requires
varunj-msft d4ccd50
Merge origin/main
varunj-msft ed01798
Merge origin/main
varunj-msft 98766ec
Record a saved entry's name clash wherever a launch script can catch it
varunj-msft 6fb1e00
Merge origin/main
varunj-msft 405c2bd
Import from public packages, as main now requires
varunj-msft d35eea9
Merge origin/main
varunj-msft 13bd3ab
Check a target that takes no credentials as the default auth mode
varunj-msft 2b97d83
Merge origin/main
varunj-msft 622bbb8
Report storage failures with one error and answer them with 503
varunj-msft 1cae0b9
Merge the single storage error
varunj-msft eba7bf2
Escape file names once and simplify the saved recipe models
varunj-msft 9f24124
Merge the recipe model simplification
varunj-msft 2bbfc8f
Report restore bugs as build errors and log each failure once
varunj-msft 3735dbc
Merge the restore logging and build error fixes
varunj-msft ca7563d
Stay ready when a saved entry can't be restored, and hold its name
varunj-msft a9dfc86
Merge the stay-ready restore
varunj-msft 67416f1
Reset the registries between runtime tests, as a real startup does
varunj-msft e6e419e
Merge the runtime test isolation
varunj-msft 81c0317
Stop a launch whose script takes the name of a saved entry that failed
varunj-msft 6ee84f0
Merge origin/main
varunj-msft d43a7e8
Merge origin/main
varunj-msft 0664063
Merge origin/main
varunj-msft 3b3ac59
Merge origin/main
varunj-msft 04fe60f
Merge origin/main
varunj-msft 6911327
Merge origin/main
varunj-msft ee45962
Refuse OpenAI targets while the server sets OPENAI_CUSTOM_HEADERS
varunj-msft 6a98d17
Merge origin/main
varunj-msft 4a3f2e5
Use final origin names, record startup entries at registration, and t…
varunj-msft 51d4fff
Explain that a credential refusal also covers using this server's cre…
varunj-msft a3d4f92
Merge the credential explanation
varunj-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[AI assisted]: [Low] The folder created by
mkdtempSyncis never deleted, so each seeded run leaves one behind in the temp directory. Removing it in a global teardown would clean it up.