FIX: reject non-finite AudioEcho parameters - #2566
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
FIX: reject non-finite AudioEcho parameters#2566Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AudioEchoConvertervalidates the numeric ranges ofdelayanddecay, but IEEE-754 NaN passes ordinary range comparisons.delay=float("nan")therefore constructs successfully and fails later when the converter calculates the integer delay in samples, while non-finite decay values can propagate invalid audio data.This change requires both parameters to be finite in addition to their existing range constraints:
delaymust be finite and greater than zero.decaymust be finite and strictly between zero and one.Invalid configuration now fails immediately with a clear
ValueError.Tests
Adds regression coverage for NaN, positive infinity and negative infinity for both
delayanddecay, while preserving the existing zero, negative and out-of-range validation.