FIX: associate converter parameter controls with visible labels - #2561
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2506.
Converter parameter names are rendered visually but are not programmatically associated with their controls, leaving textboxes, switches, selects, and file inputs unnamed or named only by their current value/placeholder for assistive technology.
This change connects each control to its existing visible parameter label with
aria-labelledby, keeps the required marker visual-only, exposes required/invalid state explicitly, and connects validation/type hint text througharia-describedby.Tests
Adds role/name coverage for text, boolean, choice, and file parameter controls, plus required-state and validation-description coverage.