FIX: reject non-finite AudioSpeed speed factors - #2560
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
FIX: reject non-finite AudioSpeed speed factors#2560Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AudioSpeedConvertervalidates thatspeed_factoris greater than zero and at most 100, but floating-point NaN passes both comparisons.A
speed_factor=float("nan")therefore constructs successfully and fails later during resampling when the converter tries to calculate an integer output length. Infinite values should also be rejected explicitly as invalid configuration.This change requires
speed_factorto be finite in addition to the existing range constraints, so invalid values fail immediately with a clearValueError.Tests
Adds regression coverage for NaN, positive infinity, and negative infinity while preserving the existing zero and negative-value checks.