FIX: associate converter parameter controls with visible labels - #2555
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2506.
Converter parameter forms render visible parameter names, but the text, boolean, choice, and file controls are not programmatically associated with those labels. Screen readers can therefore announce unnamed or ambiguous controls.
This change associates each control with its visible parameter name using
aria-labelledbyand connects parameter descriptions witharia-describedby. File browse buttons also receive a parameter-specific accessible name.Tests
Adds regression coverage for text, boolean, choice, and file parameter controls using role/name queries.