-
Notifications
You must be signed in to change notification settings - Fork 815
feat: expand SupportedContentType enum with common media types #2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lxcxjxhx
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
lxcxjxhx:feat/expand-supported-content-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
531e33a
feat: expand SupportedContentType enum with common media types
lxcxjxhx db28e7a
fix: integrate MIME type selection into file upload flow
lxcxjxhx db7eb8f
fix: update notebook import to use consolidated SupportedContentType
lxcxjxhx 8586036
Merge remote-tracking branch 'origin/main' into pr-2233
lxcxjxhx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these values change normal upload behavior:
AzureSQLMemoryleavesAzureBlobStorageIOat itstext/plaindefault, and serializers cannot pass a per-file content type. Please wire MIME selection intowrite_file_async(or infer it from the path/serializer) and consolidate the separateAzureBlobStorageTargetenum; otherwise this does not enable the advertised media types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the detailed feedback, @romanlutz! I've addressed your concerns:
Modified
AzureBlobStorageIO.write_file_async: Added an optionalcontent_typeparameter that allows specifying the MIME type per file.Auto-detection of MIME types: Implemented logic using
mimetypes.guess_typeto automatically infer the content type from file extensions when not explicitly provided.Updated serializers: Modified
save_data_async,save_b64_image_async, andsave_formatted_audio_asyncto pass the inferredcontent_typewhen saving data.Consolidated
SupportedContentTypeenum: Removed the duplicateAzureBlobStorageTargetenum and unified the content type definitions inpyrit.memory.storage.storage.Added unit tests: Created tests to verify the content type inference and propagation logic.
Testing: Due to local environment constraints (incomplete dependencies on Windows), I'm relying on the CI/CD pipeline to run the full test suite automatically.
The changes should now properly enable the advertised media types by wiring MIME selection into the file upload workflow. Please let me know if you need any additional modifications!