Repository navigation
fix: Dev to main merge - #1174
Merged
Merged
Conversation
fix: resolve the security incident
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The undocumented CLI-only development credential change can break environments relying on other credential sources.
1 open finding
What changed in this PR
Adds production environment identification, updates Azure credential selection, and regenerates deployment templates with Bicep 0.46.1.
Changes:
- Adds
APP_ENV=prodto MCP container deployments. - Uses Azure CLI locally and managed identity when deployed.
- Updates related tests and generated ARM templates.
| File | Description |
|---|---|
src/mcp_server/services/image_service.py |
Selects credentials by environment. |
src/backend/common/config/app_config.py |
Changes local Azure authentication. |
src/backend/agents/agent_template.py |
Updates agent credential selection. |
src/tests/mcp_server/test_image_service.py |
Tests MCP credential branches. |
src/tests/backend/common/config/test_app_config.py |
Updates configuration credential tests. |
src/tests/backend/agents/test_agent_template.py |
Updates agent credential mocks. |
src/tests/agents/test_agent_template_integration.py |
Updates integration credential mocks. |
infra/avm/main.bicep |
Adds MCP production environment variable. |
infra/avm/main.json |
Regenerates the AVM template. |
infra/bicep/main.bicep |
Adds MCP production environment variable. |
infra/bicep/main.json |
Regenerates the vanilla template. |
infra/main.json |
Regenerates the deployment router template. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Prajwal-Microsoft
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
This pull request introduces a new environment variable for the container app deployments and updates the Bicep-generated infrastructure templates to use a newer Bicep compiler version. The most significant change is the addition of the
APP_ENVenvironment variable set toprod, which helps distinguish production deployments. Additionally, all generated JSON templates now reflect the upgrade to Bicep version 0.46.1.Environment configuration:
APP_ENV, with the valueprodto the container app environment variables in bothinfra/avm/main.bicepandinfra/bicep/main.bicep. This change is also reflected in the generated JSON templates. [1] [2] [3]Infrastructure as Code tooling:
templateHashvalues throughout the files. This affects bothinfra/avm/main.jsonandinfra/bicep/main.json. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information