Skip to content

fix: Dev to main merge - #1174

Merged
Prajwal-Microsoft merged 2 commits into
mainfrom
dev
Oct 12, 2026
Merged

Prajwal-Microsoft merged 2 commits into
mainfrom
dev

Conversation

@Dhruvkumar-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces a new environment variable for the container app deployments and updates the Bicep-generated infrastructure templates to use a newer Bicep compiler version. The most significant change is the addition of the APP_ENV environment variable set to prod, which helps distinguish production deployments. Additionally, all generated JSON templates now reflect the upgrade to Bicep version 0.46.1.

Environment configuration:

  • Added a new environment variable, APP_ENV, with the value prod to the container app environment variables in both infra/avm/main.bicep and infra/bicep/main.bicep. This change is also reflected in the generated JSON templates. [1] [2] [3]

Infrastructure as Code tooling:

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
agents
   agent_template.py29512358%99, 134, 139, 161–162, 164, 168, 171, 176, 181–187, 192–194, 207, 211–222, 225–229, 232, 234–236, 240–241, 245, 252, 254, 256, 260, 265, 272, 277, 282, 287, 289, 293, 304, 309, 336–339, 356–358, 363–364, 382–385, 388, 390–400, 405, 409–410, 423, 428, 450–456, 460–462, 497, 513, 518, 529–530, 532, 546, 568–569, 596–597, 656, 661, 668, 682–683, 727, 729, 732–733, 736, 738, 746–747, 750–751
common/config
   app_config.py116793%164–170
TOTAL383555285% 

Tests Skipped Failures Errors Time
841 0 💤 0 ❌ 0 🔥 8.256s ⏱️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The undocumented CLI-only development credential change can break environments relying on other credential sources.

1 open finding
What changed in this PR

Adds production environment identification, updates Azure credential selection, and regenerates deployment templates with Bicep 0.46.1.

Changes:

  • Adds APP_ENV=prod to MCP container deployments.
  • Uses Azure CLI locally and managed identity when deployed.
  • Updates related tests and generated ARM templates.
File Description
src/​mcp_server/​services/​image_service.py Selects credentials by environment.
src/​backend/​common/​config/​app_config.py Changes local Azure authentication.
src/​backend/​agents/​agent_template.py Updates agent credential selection.
src/​tests/​mcp_server/​test_image_service.py Tests MCP credential branches.
src/​tests/​backend/​common/​config/​test_app_config.py Updates configuration credential tests.
src/​tests/​backend/​agents/​test_agent_template.py Updates agent credential mocks.
src/​tests/​agents/​test_agent_template_integration.py Updates integration credential mocks.
infra/​avm/​main.bicep Adds MCP production environment variable.
infra/​avm/​main.json Regenerates the AVM template.
infra/​bicep/​main.bicep Adds MCP production environment variable.
infra/​bicep/​main.json Regenerates the vanilla template.
infra/​main.json Regenerates the deployment router template.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/backend/common/config/app_config.py
@Prajwal-Microsoft
Prajwal-Microsoft merged commit eddeff6 into main Oct 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants