Repository navigation
fix: resolve the security incident - #1173
Merged
Merged
Conversation
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The description incorrectly states that application logic and compatibility are unchanged despite narrowing supported development credential sources.
1 open finding
What changed in this PR
Restricts Azure credential selection to Azure CLI in development and managed identity in deployments, while explicitly configuring MCP containers for production.
Changes:
- Replaced
DefaultAzureCredentialwith environment-specific credentials. - Added credential-selection tests.
- Added
APP_ENV=prodand regenerated ARM templates.
| File | Description |
|---|---|
src/backend/common/config/app_config.py |
Updates credential selection. |
src/backend/agents/agent_template.py |
Uses CLI or managed identity credentials. |
src/mcp_server/services/image_service.py |
Updates image-service authentication. |
src/tests/backend/common/config/test_app_config.py |
Updates credential tests. |
src/tests/backend/agents/test_agent_template.py |
Updates credential mocks. |
src/tests/agents/test_agent_template_integration.py |
Updates integration-test mocks. |
src/tests/mcp_server/test_image_service.py |
Tests environment-based credentials. |
infra/bicep/main.bicep |
Sets MCP production environment. |
infra/avm/main.bicep |
Sets MCP production environment. |
infra/bicep/main.json |
Regenerates vanilla ARM output. |
infra/avm/main.json |
Regenerates AVM ARM output. |
infra/main.json |
Regenerates combined ARM output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Roopan-Microsoft
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
This pull request makes a small but important update to the deployment configuration for both AVM and vanilla Bicep environments. The main change is the addition of a new environment variable,
APP_ENV, set to'prod'for the container app modules. Additionally, the generated ARM templates reflect an updated Bicep compiler version and new template hashes, which are a result of this and possibly other minor changes.Key changes:
Deployment Configuration Updates
APP_ENVwith the value'prod', to the container app environment variables in bothinfra/bicep/main.bicepandinfra/avm/main.bicep, ensuring the application runs in production mode by default. [1] [2]main.jsonin bothinfra/bicepandinfra/avm) now include theAPP_ENVvariable in the container app's environment variables.Bicep Compiler and Template Hash Updates
0.44.1.10279to0.46.1.21595. This affects the_generatormetadata in multiple places. [1] [2]main.jsonfiles)No application logic was changed; these updates are focused on deployment environment consistency and template generation.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information