Skip to content

Make precedence source ordered - #623

Open
linglingye001 wants to merge 2 commits into
mainfrom
linglingye/precedence-source-ordered
Open

Make precedence source ordered#623
linglingye001 wants to merge 2 commits into
mainfrom
linglingye/precedence-source-ordered

Conversation

@linglingye001

@linglingye001 linglingye001 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Why this PR?

Fix #621

ConfigurationFeatureDefinitionProvider always evaluates the Microsoft schema first, source order is never consulted when the same flag is split across schemas. A Microsoft-schema definition from the first provider beats a .NET-schema definition from every later provider.

Visible Changes

  • Tracks which schema last defines each feature by configuration-source order.
  • Later sources win across .NET and Microsoft schemas when custom merging is enabled.
  • Microsoft schema wins when both schemas occur in the same source.
  • Deduplicates cross-schema entries during feature enumeration.
  • Leaves default, non-custom behavior unchanged.

Example

When custom merging is enabled:

Provider` 1: Microsoft schema → MyFlag = false
Provider 2: .NET schema → MyFlag = targeting filter

Winning schema map:
MyFlag → .NET

Result: Provider 2 wins and the targeting filter is parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft-schema flag in appsettings.json silently shadows the same flag from Azure App Configuration (.NET schema)

1 participant