[CI] Verify checksums of binary downloads - #1325
[CI] Verify checksums of binary downloads#1325Mark Hildebrand (hildebrandmw) wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens DiskANN CI supply-chain security by adding SHA-256 verification for externally downloaded binary artifacts (datasets for disk benchmarks and Intel SDE for emulation-based CI jobs).
Changes:
- Add expected dataset archive SHA-256 values to the disk benchmark workflow matrices and pass them into the setup action.
- Extend the
setup-disk-benchmarkcomposite action to verify the downloaded dataset archive checksum before extraction. - Add an Intel SDE SHA-256 env var and verify the downloaded SDE tarball checksum in CI before extracting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/disk-benchmarks.yml | Adds dataset archive SHA-256 entries to the benchmark matrix and passes them to the setup action. |
| .github/workflows/disk-benchmarks-aa.yml | Adds dataset archive SHA-256 entries to the A/A benchmark matrix and passes them to the setup action. |
| .github/workflows/ci.yml | Adds SDE_SHA256 and verifies the Intel SDE tarball checksum during download. |
| .github/actions/setup-disk-benchmark/action.yml | Adds sha256 input and verifies dataset archive checksum before extraction. |
Suppressed comments (1)
.github/workflows/ci.yml:407
- Same as the other SDE job: checksum verification only runs on cache-miss, so cached contents aren’t validated. If the goal is supply-chain hardening, add integrity validation for the cached payload as well.
- name: Download Intel SDE
if: steps.cache-sde.outputs.cache-hit != 'true'
run: |
set -euxo pipefail
SDE_URL="https://downloadmirror.intel.com/915934/${SDE_VERSION}.tar.xz"
wget -qO intel-sde.tar.xz "$SDE_URL"
echo "${SDE_SHA256} intel-sde.tar.xz" | sha256sum --check
mkdir -p intel-sde
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
+ Coverage 91.56% 92.55% +0.98%
==========================================
Files 522 522
Lines 99541 99541
==========================================
+ Hits 91144 92128 +984
+ Misses 8397 7413 -984
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Validate the checksums of binary artifacts downloaded in CI. There is one more that I'm aware of in setup-disk-benchmark that is tracked in #1324.