Jegao/mutiple filtered test by Sanhaoji2 · Pull Request #1319 · microsoft/DiskANN

Jerry Gao (Sanhaoji2) · 2026-08-11T09:34:54Z

Does this PR have a descriptive title that could go in our release notes?
Does this PR add any new dependencies?
Does this PR modify any existing APIs?
Is the change to the API backwards compatible?
Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

Adds a production-style, query-time filter-match path for multihop search and the benchmark/report artifacts from the multiple-filter evaluation. diskann-label-filter: - New live_filter module: InlineAttributeIndex (builder) -> FrozenAttributeIndex exposing a QueryLabelProvider whose is_match evaluates an AND/OR (+equality) predicate live, per visited node, against the node's roaring attribute-id set (lock-free read, integer-encoded terminals, no FFI, no global posting list). NOT/relational operators are rejected; evaluation errors are treated as non-match. Includes unit tests. diskann-benchmark: - New search type 'topk-multihop-live-filter' (plugin + SearchPhase wiring) that builds the attribute index once from the label file and evaluates the filter live during search, so reported latency includes the real per-node filter cost. - filters.rs helpers: build_inline_attribute_index / make_live_providers. diskann-benchmark-core / diskann-benchmark-runner: - Add p99.9 latency percentile to the search output (percentiles, knn Summary, result DTO + console table). Adds diskann-benchmark/multiple_filter_test_report.md documenting the 9-case multihop vs beta vs live-filter comparison (recall + latency incl. p90/p99/p99.9). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Adds InlineAttributeIndexCsr/FrozenAttributeIndexCsr, an alternative to the roaring InlineAttributeIndex that stores each node's sorted attribute-ids in a flat CSR layout (offsets: Vec<u32> + values: Vec<u32>). is_match reads one contiguous row and answers each equality terminal with a binary_search, avoiding the HashMap probe and RoaringTreemap heap pointer-chases of the roaring path. Reuses AttributeEncoder/EncodedFilterExpr so predicate parsing, semantics, and errors are identical. Exported from lib.rs; includes parity unit tests asserting CSR == roaring per node. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19cdd8e8-cc28-4b87-af2b-97a3f1ac9488

New criterion bench (live_filter_bench) comparing the per-node is_match cost of three representations of the same corpus/predicate: roaring treemap (current), flat CSR, and per-attribute posting bitmaps. All three are asserted to agree on every probe before timing. Tunable via LF_BENCH_N / LF_BENCH_PROBES. Run: cargo bench -p diskann-label-filter --bench main -- live_filter. Also repairs evaluator_bench, which used the removed \\\ operator and panicked at setup, blocking the shared bench binary; swapped for equivalent exact-array \\\ clauses. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19cdd8e8-cc28-4b87-af2b-97a3f1ac9488

New multihop live-filter search type backed by the flat-CSR attribute index instead of the roaring HashMap<u32, RoaringTreemap>. Identical traversal and recall to topk-multihop-live-filter; only the per-node is_match differs. Wires the SearchPhase variant (graph_index.rs), the plugin (plugins.rs), registration + Plugin impl (benchmarks.rs), and build_inline_attribute_index_csr / make_live_providers_csr (filters.rs). End-to-end on the 10M index (k=150, L=150, 1 thread): 3.4x (S1) - 4.4x (S4) lower mean/p99 latency at equal recall. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19cdd8e8-cc28-4b87-af2b-97a3f1ac9488

New section 8.1 documenting the is_match microbenchmark (roaring 14-20x slower than flat CSR) and the end-to-end A/B of topk-multihop-live-filter vs -csr (3.4-4.4x lower latency at equal recall), plus CSR artifacts in section 9. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19cdd8e8-cc28-4b87-af2b-97a3f1ac9488

bin_cast: widen a DiskANN .bin file's element type (u8/i8/f16 -> f32). tsv_to_diskann_bin: convert a label-tagged TSV of embeddings into DiskANN bin + JSONL label/predicate files for compute_groundtruth and the filtered-search benchmark. Both are standalone CLIs used to prepare the multiple-filter test data. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 19cdd8e8-cc28-4b87-af2b-97a3f1ac9488

Add posting-list materialization, selectivity-adaptive CSR/bitmap selection, and bit-sliced lookup providers with parity and boundary tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Expose bitmap, adaptive, and bit-sliced multihop search modes. Recreate lazy providers for every repetition and search-L run so materialization remains part of measured query latency. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Document the posting bitmap crossover and the adaptive and bit-sliced results, including latency, selectivity, and memory tradeoffs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Codecov Comments Bot (codecov-commenter) · 2026-08-11T09:55:30Z

Codecov Report

❌ Patch coverage is 67.01571% with 1134 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.53%. Comparing base (16c7451) to head (0aadf55).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
diskann-benchmark/src/index/benchmarks.rs	10.58%	338 Missing ⚠️
diskann-benchmark/src/utils/filters.rs	65.11%	217 Missing ⚠️
diskann-label-index/src/lib.rs	86.72%	168 Missing ⚠️
diskann-benchmark/src/inputs/graph_index.rs	0.00%	130 Missing ⚠️
diskann-tools/src/bin/tsv_to_diskann_bin.rs	0.00%	123 Missing ⚠️
diskann-label-filter/src/live_filter.rs	90.56%	72 Missing ⚠️
diskann-benchmark/src/index/search/knn.rs	0.00%	42 Missing ⚠️
diskann-tools/src/bin/bin_cast.rs	0.00%	41 Missing ⚠️
diskann-benchmark/src/index/result.rs	89.47%	2 Missing ⚠️
diskann-benchmark-core/src/search/graph/knn.rs	90.90%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (67.01%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   91.26%   90.53%   -0.74%     
==========================================
  Files         517      521       +4     
  Lines       98511   101946    +3435     
==========================================
+ Hits        89910    92298    +2388     
- Misses       8601     9648    +1047

Flag	Coverage Δ
miri	`90.53% <67.01%> (-0.74%)`	⬇️
unittests	`90.22% <67.01%> (-0.73%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
diskann-benchmark-runner/src/utils/percentiles.rs	`100.00% <100.00%> (ø)`
diskann-benchmark/src/index/search/plugins.rs	`71.17% <100.00%> (+10.67%)`	⬆️
diskann/src/graph/search/multihop_filter_search.rs	`100.00% <100.00%> (ø)`
diskann-benchmark-core/src/search/graph/knn.rs	`84.87% <90.90%> (+0.22%)`	⬆️
diskann-benchmark/src/index/result.rs	`51.83% <89.47%> (+2.82%)`	⬆️
diskann-tools/src/bin/bin_cast.rs	`0.00% <0.00%> (ø)`
diskann-benchmark/src/index/search/knn.rs	`54.92% <0.00%> (-23.08%)`	⬇️
diskann-label-filter/src/live_filter.rs	`90.56% <90.56%> (ø)`
diskann-tools/src/bin/tsv_to_diskann_bin.rs	`0.00% <0.00%> (ø)`
diskann-benchmark/src/inputs/graph_index.rs	`44.29% <0.00%> (-8.41%)`	⬇️
... and 3 more

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Magdalen Dobson Manohar (magdalendobson) · 2026-08-12T17:06:56Z

If this is intended to merge to main rather than being speculative/experimental changes, let me know and I can start a preliminary review.

Jerry Gao (Sanhaoji2) and others added 26 commits July 15, 2026 20:40

diskann-label-filter: add optimized live filter providers

42b8fc9

Add posting-list materialization, selectivity-adaptive CSR/bitmap selection, and bit-sliced lookup providers with parity and boundary tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: compare optimized live filter strategies

6b10278

Document the posting bitmap crossover and the adaptive and bit-sliced results, including latency, selectivity, and memory tradeoffs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-label-filter: add flat bitslice DNF evaluation

8eb344c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-benchmark: add bitslice DNF search mode

9b77d7e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann: reuse scratch in multihop expansion

f4b0b33

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: record filtered search optimizations

aede0d1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge origin/main into jegao/MutipleFilteredTest

df41836

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-benchmark: add inline Bitslice DNF search

0893c67

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: compare filtered search strategies

0322595

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-label-filter: add encoded label indexes

17b2be3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-label-index: isolate encoded label storage

f394424

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-label-index: decouple query storage

7b51f7e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-label-index: add AST query expressions

a6451b8

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-label-index: support recursive AST queries

bae9e73

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-benchmark: compare encoded filter expressions

a5de3b6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: record encoded expression benchmarks

4c58e96

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diskann-benchmark: include encoded query costs

5eadb21

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: report query-inclusive filter latency

fa256c1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: summarize multi-filter ANN optimization

0aadf55

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Navigation Menu

Uh oh!

Jegao/mutiple filtered test - #1319

Jegao/mutiple filtered test#1319
Jerry Gao (Sanhaoji2) wants to merge 26 commits into
mainfrom
jegao/MutipleFilteredTest

Jerry Gao (Sanhaoji2) commented Aug 11, 2026

Uh oh!

Codecov Comments Bot (codecov-commenter) commented Aug 11, 2026

Uh oh!

Magdalen Dobson Manohar (magdalendobson) commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Jerry Gao (Sanhaoji2) commented Aug 11, 2026

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

Uh oh!

Codecov Comments Bot (codecov-commenter) commented Aug 11, 2026

Codecov Report

Uh oh!

Magdalen Dobson Manohar (magdalendobson) commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants