Repository navigation
RDAT: Reserve mesh-node preview table identifiers - #9099
Merged
Jesse Natalie (jenatali) merged 1 commit intoNov 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The serialized LinAlg metadata renumbering requires coordinated compiler-package and RDAT-consumer updates, but this compatibility requirement is missing from the release notes.
1 open issue
What changed in this PR
This PR preserves RDAT compatibility with mesh-node preview metadata by reserving its serialized table IDs and relocating LinAlg tables. Compiler packages and RDAT consumers must be updated together.
Changes:
- Reserve legacy shader-info IDs 13–21 and relocate LinAlg-related tables to IDs 22–29.
- Map legacy shader-info IDs to the current reader tables.
- Add regression tests for all legacy shader-info IDs and legacy mesh info alongside relocated extended function properties.
| File | Description |
|---|---|
| tools/clang/unittests/HLSL/DxilContainerTest.cpp | Adds legacy-ID and mixed-table compatibility tests. |
| include/dxc/DxilContainer/DxilRuntimeReflection.inl | Recognizes legacy preview shader-info IDs when reading RDAT. |
| include/dxc/DxilContainer/DxilRuntimeReflection.h | Reserves preview IDs and relocates LinAlg-related table IDs. |
Review effort: Balanced
Jesse Natalie (jenatali)
force-pushed
the
reserve-mesh-node-rdat-ids
branch
from
November 4, 2026 23:49
5fd25a0 to
dd0dbff
Compare
Jesse Natalie (jenatali)
force-pushed
the
reserve-mesh-node-rdat-ids
branch
from
November 5, 2026 00:06
dd0dbff to
e0d2a3b
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Active experimental shader-info IDs fall within the released range, breaking the required public-enum separation, and the serialized RDAT compatibility change lacks release-note coverage.
2 open issues
Review effort: Balanced
Chris B (llvm-beanz)
approved these changes
Nov 5, 2026
Chris B (llvm-beanz)
left a comment
Chris B (llvm-beanz)
left a comment
Collaborator
There was a problem hiding this comment.
Seems unfortunate, but reasonable to me given the constraints.
Keep the experimental shader-info tables at IDs 13-21 used by the mesh-node preview and move LinAlg tables to IDs 22-29. Use one set of identifiers for both emitted and previously compiled metadata. Gate experimental shader-info table emission independently of ID ordering. Released validated targets must omit these tables, while prerelease targets and validator 0.0 retain existing experimental behavior. Add wire-compatibility regressions and strengthen the existing SM6.10 emission checks. Compiler packages and RDAT consumers must be updated together because the new LinAlg table IDs change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ff1c28a-cad2-4e86-9c05-8d1cc1a2744e
Jesse Natalie (jenatali)
force-pushed
the
reserve-mesh-node-rdat-ids
branch
from
November 5, 2026 17:23
e0d2a3b to
0d6916c
Compare
Ashley Coleman (V-FEXrt)
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve the experimental shader-info table IDs serialized by the mesh-node preview, not just its dedicated table ID. Move the new LinAlg tables above the reserved range and recognize legacy shader-info IDs when reading RDAT.
Keep current experimental tables above the released range so released shader targets do not start emitting experimental metadata. Add regression cases for all legacy table IDs and for legacy mesh info alongside the relocated extended function properties.
Compiler packages and RDAT consumers must be updated together because the new LinAlg table IDs change.