convert NamedTuples to @dataclass #38

Activity

1. blumu commented on Sep 14, 2021

   

   William Blum (blumu)

   on Sep 14, 2021

   Contributor

   More actions

   If I recall correctly, we favor NamedTuple whenever possible so that the underlying data structure is guaranteed to be immutable by default. We use @dataclasses when mutability is required.
   Replacing NamedTuple by @dataclasses may not alter the program behavior though it may prevent the type-checker from detecting potential bugs caused by mutations.

   That said if that causes problems for the wrapper you are writing, we could change this convention. I see that @dataclasses were introduced in python 3.7 and that they also support immutability via the frozen flag, so I wonder if it was meant to fully replace NamedTuple though the doc does not clarify: https://docs.python.org/3/library/dataclasses.html
2. jonabox commented on Sep 14, 2021

   

   Jonathan Esteban (jonabox)

   on Sep 14, 2021

   Last edited by jonabox

   Author

   More actions

   Ahh, that's great reasoning. A big part of the project I'm working on is letting users modify generated models such as adding nodes, updating vulnerability descriptions, etc. This would be easier (albeit riskier) to do with mutable @dataclasses but perhaps frozen @dataclasses would strike a good balance.

   Also, @dataclasses have been a lot easier for me to serialize into JSON as opposed to NamedTuples, which did not yield me good results. It might be that they were not designed with that functionality in mind. On my end, I had to change a couple NamedTuples into @dataclasses to be able to send data over to the frontend. (I tried using the YAML serializer but that brought me a few problems, unfortunately.)
3. blumu commented on Dec 17, 2021

   

   William Blum (blumu)

   on Dec 17, 2021

   Contributor

   More actions

   Jonathan Esteban (@jonabox) Have you tried the orjson serialization package (https://github.com/ijl/orjson/) mentioned in one of the answers to the stackoverflow article you cited? According to the doc it handles NameTuples correctly.
4. William Blum (blumu)

   added

   enhancementNew feature or requestNew feature or request

   on Dec 17, 2021
5. jonabox commented on Dec 17, 2021

   

   Jonathan Esteban (jonabox)

   on Dec 17, 2021

   Last edited by jonabox

   Author

   More actions

   Not quite, I ended up changing NamedTuples into @dataclasses(), some of them frozen. I then added an encode method to these classes to fine-control the json.dumps() output. For example:

   @dataclass(frozen=True)
   class CachedCredential():
       """Encodes a machine-port-credential triplet"""
       node: NodeID
       port: PortName
       credential: CredentialID
   
       def encode(self):
           return dataclasses.asdict(self)
   
   cachedCredential = CachedCredential(node="client", port="TCP",  credential="TCP-credential" )
   json.dumps(cachedCredential, default=lambda x: x.encode())
   # returns {"node": "client", "port": "TCP",  "credential": "TCP-credential"}

   I might still try orjson, and get back with any findings, but those slight modifications have worked really well for me so far.