Exclude test code from coverage reports - #8255
Merged
Amaury Chamayou (achamayou) merged 1 commit intoSep 1, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
September 1, 2026 20:18
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The script’s CLI help text is now out of date with the newly expanded coverage exclusions and should be updated to match actual behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the LLVM coverage aggregation script to exclude non-framework sources so coverage reports focus on CCF’s core implementation rather than the code exercising it.
Changes:
- Expand
llvm-cov’s-ignore-filename-regexto filter out third-party, test, and performance paths.
File summaries
| File | Description |
|---|---|
| scripts/coverage.sh | Extends the ignore regex for llvm-cov coverage reporting to exclude additional non-framework code paths. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Max (maxtropets)
approved these changes
Sep 1, 2026
Amaury Chamayou (achamayou)
deleted the
achamayou-fix-coverage-calculation
branch
September 1, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation