[Alexander Holstrup (aholstrup1)]

Fixes AB#653393

What & why

Revert commit 3f357d6, merged through #12325, as requested following the failures in workflow run 37598783939.

This is the full 21-file revert, not just a test-exclusion change. It removes enableCleanTestCodeunitExecution: true, restores the prior Expense API authentication helper and 51 Expense API exclusions, removes the 193 temporary general API exclusions introduced by that commit, and rolls back its consolidated production/test changes. Subsequent AL-Go settings updates are preserved.

The run has 19 integration-test jobs with Expense API HTTP 500 failures, two runner-disconnection failures, and one downstream status-check failure. Italy also has ten Avalara E2E test failures caused by shipment number-series date validation. The API errors report Object reference not set to an instance of an object; the available test call stacks do not identify the server-side null reference. This rollback mitigates the related enablement change, but does not prove that the underlying runtime defect is fixed.

Failure breakdown for all 22 jobs

• Users = EmployeesAPICanFilterExpenseUsers in Expense Users API Test (148315).
• Capabilities = CapabilitiesProjectsEnabledViaAPI in Expense Capabilities API Test (148318).
• Activity = ActivityLogEntryIsExposedThroughReadOnlyAPI in Expense Activity Log API Test (148343).

Each failed because its GET returned HTTP 500 with a null-reference error instead of HTTP 200. Verified against complete test-job logs, not just the generic There are test failures! wrapper or truncated annotations.

Job	Failure
DK IntegrationTests	Users
CH IntegrationTests	Capabilities
ES IntegrationTests	Users; Activity
CA IntegrationTests	Users
CZ IntegrationTests	Capabilities
AT IntegrationTests	Self-hosted runner lost communication with GitHub; no failed test step recorded.
DE IntegrationTests	Capabilities
BE IntegrationTests	Users
GB UncategorizedTests	Self-hosted runner lost communication with GitHub; no failed test step recorded.
FI IntegrationTests	Users
GB IntegrationTests	Capabilities; Activity
AU IntegrationTests	Users
SE IntegrationTests	Capabilities
MX IntegrationTests	Users
IT IntegrationTests	Capabilities; ten Avalara E2E tests failed during invoice posting: You cannot assign new numbers from the number series S-SHPT on a date before 10/07/26.
NZ IntegrationTests	Users
W1 IntegrationTests	Users; Activity
US IntegrationTests	Users
NL IntegrationTests	Capabilities
NO IntegrationTests	Capabilities
IS IntegrationTests	Capabilities
Pull Request Status Check	Failed because the preceding 21 jobs failed; not an additional build defect.

Italy's additional failures are in End-to-End Tests (133625), app E-Document Connector - Avalara Tests: E2E_OutboundInvoice_Error_ManualResend_Complete, E2E_MultipleDocuments_IndependentLifecycles, E2E_ServiceDown_ThenRecover, E2E_ActivationThenSubmit_Complete, E2E_ConnectionSetup_SelectCompany_ThenSubmit, E2E_SendModeTest_SubmitSucceeds, E2E_BlockedMandate_Unblock_Resend_Complete, E2E_StatusCheck_HttpError_RetrySucceeds, E2E_PageVerification_AllStatusTransitions, and E2E_MessageResponseHeader_PopulatedDuringGetResponse. Their call stacks reach Library - E-Document.PostInvoice -> Sales-Post.UpdateShippingNo -> No. Series.GetNextNo, before the intended connector lifecycle is exercised.

The runner annotations establish lost communication, but do not distinguish machine termination, resource exhaustion, or network failure.

Linked work

Tracking bug: AB#653393 - intermittent Expense API HTTP 500 / SQL-pool null-reference failures after clean-tenant resets. Related to AB#646383. This is a non-closing link: the rollback mitigates CI blocking by reducing coverage, but does not establish that the underlying runtime defect is fixed.

Reverts #12325. Related failure run: https://github.com/microsoft/BCApps/actions/runs/37598783939.

No approved GitHub issue was supplied for this rollback; the original PR has no closing GitHub issue reference. An approved issue link remains to be added before this draft is ready for review. No issue or work item is claimed fixed.

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

• Invoke-Pester -Path '.\build\scripts\tests\ParallelTestExecution.Test.ps1' -PassThru — passed: 87 tests, 0 failed, 0 skipped. Covers existing clean-codeunit selection, ordinary execution, and rerun infrastructure; not an AL integration run.
• Compared git ls-tree 3f357d6c93edab81eab2437909d8dab17637ba0d^ -- <path> with git ls-files --stage -- <path> for every affected non-settings file — passed: all 20 exactly match the original parent blobs, including the restored helper and removed permission set. Verified exactly the original 21 changed paths. Reviewed the AL source diff and verified the settings diff only removes the enablement switch.
• Get-Content -LiteralPath <path> -Raw | ConvertFrom-Json for each changed JSON file — passed.
• git diff --cached --check — failed only on the restored helper's original blank line at EOF. Preserved that line for an exact revert. git -c core.whitespace=-blank-at-eof diff --cached --check — passed.
• No new tests added: this restores previous source, fixtures, and exclusions rather than introducing replacement behavior. The original commit's added regression tests are also reverted.
• Consulted LOCAL_DEV_ENV.md and build/scripts/tests/runTests.ps1. AL compilation and Business Central runtime tests were not run locally; no dedicated BC development container was provisioned for this rollback. Human full-diff review and runtime checkboxes remain open. CI results for this revert are pending.

Risk & compatibility

This full rollback includes production travel-request approver filtering and the associated permission/filter/date/test-fixture fixes. Restoring SelectionFilterManagement.GetSelectionFilter removes the exact-user filter fix and can reintroduce the range-gap behavior it addressed. Coverage is reduced by restoring Expense API exclusions and removing the clean-codeunit opt-in. Reintroduce the intended fixes and API coverage in a follow-up once their failures are understood.

This change does not repair the two disconnected runners or Italy's independent Avalara number-series date failure. It also does not establish that the server-side HTTP 500 null reference is resolved.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This rolls back clean-codeunit execution, restores Expense API exclusions and authentication support, and removes temporary general API exclusions to mitigate unstable HTTP 500 failures. Those test-infrastructure changes fit the mitigation, but the rollback also restores a production approver filter that can include users who were not assigned to that approver.

Problem-solution fit

Fit: Partial

The rollback reduces the failing test coverage as intended, but it also reverses an independent authorization fix that is not needed for that mitigation.

Suggestions

S1 (🔴 High): Keep exact approver membership filtering
This helper can compress assigned users such as TR-A and TR-C into TR-A..TR-C, which also exposes a request for unassigned TR-B. Keep the exact-value filter and its range-gap regression while reverting the clean-test execution changes.

Risk assessment and necessity

Risk: An approver can see pending travel requests assigned to another approver when an unassigned user number falls between two assigned values. The BaseApp SelectionFilterManagement implementation was checked and intentionally compresses consecutive values into ranges; no event publisher or event-order dependency is involved.

Necessity: The CI mitigation is necessary, but reverting this separate production authorization fix is not required. Keep that fix and its focused regression tests while reverting the unstable test enablement.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=12514 round=1 by=alexei-dobriansky at=2026-10-08T01:14:36.675Z lastSha=9066169bab6c24ee707d5531c86f4fbdb7c88c44 reviewKey=182a69b5a4c4b55316b212dd8b877bb68ba7e19e0b72416e3667b18629f1f0ad suggestions=S1@3f1cd2a1