[29.0] - Bug 650939 - [Expense Agent] Deleting an itemized Expense Category shows misleading missing-subcategories confirmation

[v-rohangarg20]

AB#650939

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

The change skips the missing-subcategory close confirmation while an itemized expense category is being deleted, so the category can be deleted after its subcategories are cascade-deleted. It also applies the same pattern to the expense-user close confirmation.

The direction matches the reported scenario: the warning should protect retained setup records, not a record that is being deleted. The delete flag covers the expected successful delete path, but it is set before all delete paths are known to continue, which leaves one non-blocking edge case.

Problem-solution fit

Fit: Strong

The fix addresses the reported category deletion flow and keeps the existing validation for normal page close. The extra expense-user change follows the same UX pattern, but the new guard state should be made safe when a delete attempt is canceled or rejected.

Suggestions

S1 (🟠 Moderate): Deleting flag can survive canceled deletes
Set the deleting flag only after the delete will continue, and clear it if the delete is canceled. Today the flag is set before all delete checks have succeeded, so a canceled or failed delete can leave the page open with the close-time warning disabled. This affects the same guard pattern added on both pages.

Risk assessment and necessity

Risk: Low to moderate. The change is limited to setup-page delete and close prompts in Expense Agent, not posting, amounts, or persisted cascade logic. The main regression surface is suppressing setup warnings after a delete attempt that does not actually delete the record.

Necessity: The category change is needed because deletion can legitimately remove the related subcategories before the page closes, making the old confirmation misleading. The scope is small, but the delete guard should track only a delete that really proceeds.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11707 round=1 by=alexei-dobriansky at=2026-09-22T07:13:35Z lastSha=7a392cfb9521b9eaab70c69ef6b0996511a36fdb reviewKey=60f48d66f92f1ae011fb7f0d5c0198adb96981e8ea3d0f398813b48b062e4e32 suggestions=S1@6029a756