Skip to content

[29.x] - Bug 650938: [Expense Agent] Deleting an itemized Expense Category shows misleading missing-subcategories confirmation #11706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-rohangarg20 merged 2 commits into from
Sep 23, 2026
Merged

[29.x] - Bug 650938: [Expense Agent] Deleting an itemized Expense Category shows misleading missing-subcategories confirmation #11706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bbfa03
Initial Commit
v-rohangarg20 Sep 22, 2026
5b184b2
Code Review Feedback
v-rohangarg20 Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Apps/W1/ExpenseAgent/app/src/MasterData/Pages/ExpenseCategoryCard.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,18 @@ page 6945 "Expense Category Card"

trigger OnQueryClosePage(CloseAction: Action): Boolean
Comment thread
v-rohangarg20 marked this conversation as resolved.
begin
if Rec."Expense Detail Required" = Rec."Expense Detail Required"::Itemize then
CheckShowConfirmationForSubCategories(Rec);
if not IsDeletingCategory then
if Rec."Expense Detail Required" = Rec."Expense Detail Required"::Itemize then
CheckShowConfirmationForSubCategories(Rec);
end;

trigger OnDeleteRecord(): Boolean
begin
IsDeletingCategory := true;
end;

var
IsDeletingCategory: Boolean;
ContinueWithMissingSubcategoryQst: Label 'You have not added any subcategories for expense category %1 where %2 is %3.\\ It will be required to be added before you can use this expense category.\\ Do you want to continue without adding subcategories ?', Comment = '%1 - Expense Category Code, %2 - Field Name "Expense Detail Required", %3 - Expense Detail Required';

local procedure CheckShowConfirmationForSubCategories(ExpenseCategory: Record "Expense Category")
Expand Down
11 changes: 7 additions & 4 deletions src/Apps/W1/ExpenseAgent/app/src/MasterData/Pages/ExpenseUser.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,16 +234,18 @@ page 6949 "Expense User"

trigger OnDeleteRecord(): Boolean
begin
exit(Rec.ConfirmApproverReassignment());
IsDeletingExpenseUser := Rec.ConfirmApproverReassignment();
exit(IsDeletingExpenseUser);
end;

trigger OnQueryClosePage(CloseAction: Action): Boolean
var
ConfirmManagement: Codeunit "Confirm Management";
begin
if Rec."Employee No." = '' then
if not ConfirmManagement.GetResponseOrDefault(StrSubstNo(CloseWithoutEmployeeNoQst, Rec.FieldCaption("Employee No.")), true) then
exit(false);
if not IsDeletingExpenseUser then
if Rec."Employee No." = '' then
if not ConfirmManagement.GetResponseOrDefault(StrSubstNo(CloseWithoutEmployeeNoQst, Rec.FieldCaption("Employee No.")), true) then
exit(false);
end;

trigger OnOpenPage()
Expand All @@ -260,6 +262,7 @@ page 6949 "Expense User"
var
NoFieldVisible: Boolean;
IsCreateEmployeeVisible: Boolean;
IsDeletingExpenseUser: Boolean;
CloseWithoutEmployeeNoQst: Label '%1 is blank. The expense user will not be linked to an employee.\\Are you sure you want to exit?', Comment = '%1 = Employee No. field caption';

local procedure SetCodeFieldVisible()
Expand Down
Loading