Skip to content

[29x] Bug 650434 The Non-Deductible VAT Amount is currently not taken into account in the VAT return Austria - #11579

Open
MSNehaNawal wants to merge 2 commits into
releases/29.xfrom
bugs/Bug-650139-29x-NonDeductibleVAT_VATreturnAustria
Open

MSNehaNawal wants to merge 2 commits into
releases/29.xfrom
bugs/Bug-650139-29x-NonDeductibleVAT_VATreturnAustria

Conversation

@MSNehaNawal

@MSNehaNawal MSNehaNawal commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Bug 650434: [29.x][all-e]The Non-Deductible Base/Amount and Full Base/Amount types are currently not taken into account in the VAT return Austria (Report 11110) in the Austrian version.

Fixes AB#650434

Issue-
The Non-Deductible Base/Amount and Full Base/Amount types are currently not taken into account in the VAT return Austria (Report 11110) in the Austrian version.
Cause-
The condition for Non-Deductible VAT amount was not added during the amount calculations
Solution-
Added condition for Non-Deductible VAT amount during the amount calculations.

@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 17, 2026
@MSNehaNawal MSNehaNawal changed the title Initial Commit [29x] Bug 650434 The Non-Deductible VAT Amount is currently not taken into account in the VAT return Austria Sep 17, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@MSNehaNawal
MSNehaNawal marked this pull request as ready for review September 22, 2026 04:32
@MSNehaNawal
MSNehaNawal requested a review from a team September 22, 2026 04:32
@MSNehaNawal
MSNehaNawal requested a review from a team as a code owner September 22, 2026 04:32
@MSNehaNawal MSNehaNawal reopened this Sep 22, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

The change adds handling for Non-Deductible Amount in the VAT Statement AT export and adds a purchase invoice regression test for KZ062. That covers one needed branch, but the amount calculation still ignores Non-Deductible Base, Full Amount, and Full Base, while parallel VAT statement calculation code handles all four non-deductible amount types.

Problem-solution fit

Fit: Partial

The reported problem covers non-deductible base and amount values, including the full base and full amount variants. The diff fixes only the non-deductible amount path, so some configured VAT statement lines can still produce missing or incomplete export values.

Suggestions

S1 (🔴 High): Handle all non-deductible amount types
The report now handles only Non-Deductible Amount. Add the Non-Deductible Base, Full Amount, and Full Base branches too, and cover them in the test. Otherwise those VAT statement lines still export zero or incomplete values.

Risk assessment and necessity

Risk: The changed code feeds the Austrian VAT statement FDF and XML export. If an amount type is still not calculated, the tax return output can omit values that are present in posted VAT entries. The regression surface is limited to VAT statement lines for this report, but the area is financially sensitive.

Necessity: The change is needed because the export should include non-deductible VAT values when the statement line is configured for them. The scope is too small as written because the same calculation point must handle all related amount types, not only the VAT amount case.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11579 round=1 by=alexei-dobriansky at=2026-09-22T07:11:42.8613688Z lastSha=53f2a0da3e9576e33f337573ccab84a40e7a01df reviewKey=ff2407be343d1637702397616077491142dee2f29831fd2308c295d34c78397e suggestions=S1@33468b34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants