[Main]-Re-enable BC tests disabled due to BCApps submodule migration-IT - #11234
DeepsShukla wants to merge 1 commit into
Conversation
|
| local procedure VerifyDatiFatturaAttributes(FileName: Text) | ||
| var | ||
| XMLDoc: DotNet XmlDocument; | ||
| XmlDocument: XmlDocument; |
There was a problem hiding this comment.
This refactor drops the schema-validation assertion from VerifyDatiFatturaAttributes: the helper now loads the XML and checks four root attributes via native XmlDocument/XmlElement APIs, but it no longer calls ValidateXmlAgainstXsdSchema as the old DotNet-based implementation did, and no other call site validates the Datifattura export against its XSD on this test path. In ExportedVATReportConsistsOfLinesFromOneVATReport_Datifattura, the flow is ExportFile_Datifattura -> VerifyDatiFatturaInvoiceNoAndDate -> VerifyDatiFatturaAttributes, so malformed-but-attribute-correct XML would now pass this test. Restore XSD validation in this helper (or an equivalent step earlier in the same verification flow) so the test still proves the generated document is schema-valid.
Agent judgement — not directly backed by a BCQuality knowledge article.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.41.6
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThis PR updates Italian test code so XML schema test assets can be found after the test asset layout changed. The intent is good, and one changed helper uses the right probe-and-fallback shape, but two other changed paths now hardcode the migrated layout and no longer preserve the standalone BCApps layout. Problem-solution fitFit: Partial The bug requires the same tests to pass in both layouts. The diff only does that in one file; two changed test areas can still fail when the migrated asset path is not present. SuggestionsS1 (🔴 High): Probe before changing the schema root S2 (🔴 High): Keep the legacy asset path fallback Risk assessment and necessityRisk: The regression surface is limited to test code, but it is the exact test code this change is trying to re-enable. If the hardcoded paths stay, some tests can still fail in one supported checkout layout. Necessity: The change is necessary because the schema assets must be found after the layout move. The scope is right, but each changed schema lookup must use the same layout-agnostic pattern before the fix is complete.
|
Workitem Bug 641038: [all-e]Re-enable BC tests disabled due to BCApps submodule migration (hardcoded GDL/DemoTool paths)
Fixes AB#641038